Skip to content

Commit 990010d

Browse files
fix: breadcrumb with single character fails wcag 2.2 target size (#19287)
* fix: breadcrumb with single character fails wcag 2.2 target size * fix: update same spacing in web-components as well * fix: change code * fix: removed size
1 parent 42d3f0b commit 990010d

File tree

3 files changed

+20
-1
lines changed

3 files changed

+20
-1
lines changed

packages/styles/scss/components/breadcrumb/_breadcrumb.scss

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,11 @@
4949
margin-inline-end: $spacing-02;
5050
}
5151

52+
.#{$prefix}--breadcrumb--sm .#{$prefix}--breadcrumb-item .#{$prefix}--link {
53+
justify-content: center;
54+
min-inline-size: $spacing-04;
55+
}
56+
5257
.#{$prefix}--breadcrumb-item .#{$prefix}--link:visited {
5358
color: $link-primary;
5459

packages/web-components/src/components/breadcrumb/breadcrumb.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,10 @@ $css--plex: true !default;
126126
display: none;
127127
}
128128
}
129+
:host(#{$prefix}-breadcrumb-link[size='sm']) {
130+
min-inline-size: $spacing-04;
131+
text-align: center;
132+
}
129133

130134
:host(#{$prefix}-breadcrumb-link[aria-current='page']) .#{$prefix}--link {
131135
color: $text-primary;

packages/web-components/src/components/breadcrumb/breadcrumb.ts

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ class CDSBreadcrumb extends LitElement {
2929
* Specify the size of the Breadcrumb. Currently
3030
* supports the following: `sm` & `md` (default: 'md')
3131
*/
32-
@property()
32+
@property({ type: BREADCRUMB_SIZE, reflect: true })
3333
size = BREADCRUMB_SIZE.MEDIUM;
3434

3535
/**
@@ -53,6 +53,16 @@ class CDSBreadcrumb extends LitElement {
5353
super.connectedCallback();
5454
}
5555

56+
updated(changedProperties) {
57+
if (changedProperties.has('size')) {
58+
const items = this.querySelectorAll(`${prefix}-breadcrumb-item`);
59+
items?.forEach((item) => {
60+
const link = item.querySelector(`${prefix}-breadcrumb-link`);
61+
link?.setAttribute('size', this.size);
62+
});
63+
}
64+
}
65+
5666
render() {
5767
const classes = classMap({
5868
[`${prefix}--breadcrumb`]: true,

0 commit comments

Comments
 (0)