Skip to content

Commit 7956f63

Browse files
authored
fix: makes aria-label optional (#17467)
1 parent fab91fa commit 7956f63

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

packages/react/src/components/DataTable/TableExpandHeader.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ type TableExpandHeaderPropsBase = {
3131
* Specify the string read by a voice reader when the expand trigger is
3232
* focused
3333
*/
34-
['aria-label']: string;
34+
['aria-label']?: string;
3535

3636
/**
3737
* @deprecated The enableExpando prop is being replaced by `enableToggle`
@@ -150,7 +150,7 @@ TableExpandHeader.propTypes = {
150150
className: PropTypes.string,
151151

152152
/**
153-
* The enableExpando prop is being replaced by enableToggle
153+
* The enableExpando prop is being replaced by TableExpandHeader
154154
*/
155155
enableExpando: deprecate(
156156
PropTypes.bool,

packages/react/src/components/DataTable/__tests__/TableExpandHeader-test.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ describe('TableExpandHeader', () => {
3131
<TableHead>
3232
<TableRow>
3333
<TableExpandHeader
34-
ariaLabel="test-label"
34+
aria-label="test-label"
3535
isExpanded={false}
3636
onExpand={jest.fn()}
3737
className="custom-class"
@@ -43,12 +43,12 @@ describe('TableExpandHeader', () => {
4343
expect(container).toMatchSnapshot();
4444
});
4545

46-
it('should respect ariaLabel prop', () => {
46+
it('should respect aria-label prop', () => {
4747
render(
4848
<Table>
4949
<TableHead>
5050
<TableRow>
51-
<TableExpandHeader isExpanded enableToggle ariaLabel="Expand" />
51+
<TableExpandHeader isExpanded aria-label="Expand" enableToggle />
5252
</TableRow>
5353
</TableHead>
5454
</Table>

0 commit comments

Comments
 (0)