Skip to content

Commit 1232b5e

Browse files
authored
Removed duplicate onChange (#17754)
* fix: removed duplicate onChange * test: added test to make sure onchange is called once * test: fixed spelling * fix: removed test story
1 parent a7d18f1 commit 1232b5e

File tree

2 files changed

+24
-4
lines changed

2 files changed

+24
-4
lines changed

packages/react/src/components/Menu/Menu-test.js

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -254,4 +254,28 @@ describe('MenuItem', () => {
254254
spy.mockRestore();
255255
});
256256
});
257+
258+
it('should call onChange once', async () => {
259+
const onChange = jest.fn();
260+
261+
render(
262+
<Menu open label="Menu">
263+
<MenuItem label="Menu">
264+
<MenuItemRadioGroup
265+
label="MenuItemRadioGroup"
266+
items={[
267+
{ label: 'Item 1', value: '1' },
268+
{ label: 'Item 2', value: '2' },
269+
]}
270+
onChange={onChange}
271+
itemToString={(item) => item.label}
272+
/>
273+
</MenuItem>
274+
</Menu>
275+
);
276+
277+
await userEvent.click(screen.getByTitle('Menu'));
278+
await userEvent.click(screen.getByTitle('Item 1'));
279+
expect(onChange).toHaveBeenCalledTimes(1);
280+
});
257281
});

packages/react/src/components/Menu/MenuItem.tsx

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -557,10 +557,6 @@ export const MenuItemRadioGroup = forwardRef(function MenuItemRadioGroup<Item>(
557557

558558
function handleClick(item, e) {
559559
setSelection(item);
560-
561-
if (onChange) {
562-
onChange(e);
563-
}
564560
}
565561

566562
useEffect(() => {

0 commit comments

Comments
 (0)