Skip to content

fix(ui-shell): layer causing tabbing issues #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ariellalgilmore
Copy link
Member

@ariellalgilmore ariellalgilmore commented Jun 11, 2025

Closes #

tabbing issue in secondary nav

Changelog

Changed

  • moved <Layer> because when querying it's causing tabbing issues

Testing / Reviewing

make sure only can arrow key in secondary nav

Copy link

netlify bot commented Jun 11, 2025

Deploy Preview for carbon-labs-web-components failed. Why did it fail? →

Name Link
🔨 Latest commit 07f2b94
🔍 Latest deploy log https://app.netlify.com/projects/carbon-labs-web-components/deploys/684a1326db95ff0008137602

Copy link

netlify bot commented Jun 11, 2025

Deploy Preview for carbon-labs-react ready!

Name Link
🔨 Latest commit 07f2b94
🔍 Latest deploy log https://app.netlify.com/projects/carbon-labs-react/deploys/684a13260b9e7a0008bbb79c
😎 Deploy Preview https://deploy-preview-655--carbon-labs-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ariellalgilmore ariellalgilmore marked this pull request as ready for review June 11, 2025 23:40
@ariellalgilmore ariellalgilmore requested a review from a team as a code owner June 11, 2025 23:40
Copy link

@oliviaflory oliviaflory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested out Chrome, Firefox and Safari and all are arrow keys once you get past the slot

@ariellalgilmore ariellalgilmore added this pull request to the merge queue Jun 12, 2025
Merged via the queue into carbon-design-system:main with commit 7b3d828 Jun 12, 2025
12 of 16 checks passed
@ariellalgilmore ariellalgilmore deleted the fix/layer-issue branch June 12, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants