Skip to content

Commit e17fd75

Browse files
iangflemingBRIAN T. HAN
authored and
BRIAN T. HAN
committed
fix(module): rename to singular, fix visual bugs (#2436)
* fix(module): rename to singular, fix visual bugs * docs(module): move migration guide
1 parent ea308f5 commit e17fd75

File tree

5 files changed

+7
-6
lines changed

5 files changed

+7
-6
lines changed
File renamed without changes.

src/components/modules/_modules.scss renamed to src/components/module/_module.scss

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
.bx--module__inner {
2222
@include layer('raised');
2323
background-color: $ui-01;
24-
border: 1px solid $ui-04;
24+
border: 1px solid transparent;
2525
}
2626

2727
.bx--module__header {
@@ -34,6 +34,7 @@
3434
.bx--module__title {
3535
@include font-size('14');
3636
@include font-smoothing;
37+
letter-spacing: 0;
3738
font-weight: 700;
3839
color: $text-01;
3940
}

src/components/modules/migrate-to-7.x.md renamed to src/components/module/migrate-to-7.x.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
### HTML
22

3-
The Modules component has changed significantly! Here's one example of how the component can be composed.
3+
The Module component has changed significantly! Here's one example of how the component can be composed.
44

55
``` html
66
<div class="bx--module bx--module--double">
@@ -17,15 +17,15 @@ The Modules component has changed significantly! Here's one example of how the c
1717
</div>
1818
```
1919

20-
For more examples see the `modules.html` file.
20+
For more examples see the `module.html` file.
2121

2222

2323
### SCSS
2424

25-
The `_modules.scss` file is now located at __src/components/modules/modules.scss__. You'll need to update any `@import` statements for this file to reflect this change.
25+
The `_module.scss` file is now located at __src/components/modules/module.scss__. You'll need to update any `@import` statements for this file to reflect this change.
2626

2727
```scss
28-
@import 'path_to_node_modules/@console/bluemix-components/src/components/modules/modules';
28+
@import 'path_to_node_modules/@console/bluemix-components/src/components/module/module';
2929
```
3030

3131
| Old Class | New Class | Note |

src/globals/scss/styles.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ $css--reset: false !default;
4949
@import '../../components/dropdown/dropdown';
5050
@import '../../components/loading/loading';
5151
@import '../../components/modal/modal';
52-
@import '../../components/modules/modules';
52+
@import '../../components/module/module';
5353
@import '../../components/notification/inline-notification';
5454
@import '../../components/notification/toast-notification';
5555
@import '../../components/tooltip/tooltip';

0 commit comments

Comments
 (0)