Allow Throwable to trigger the crash

Author: sebastianfeldmann

src/Console/Command.php

@@ -12,10 +12,10 @@
 namespace CaptainHook\App\Console;
 
 use CaptainHook\App\Console\Runtime\Resolver;
-use Exception;
 use Symfony\Component\Console\Command\Command as SymfonyCommand;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
+use Throwable;
 
 /**
  * Class Command
@@ -81,21 +81,21 @@ public function getIO(InputInterface $input, OutputInterface $output): IO
      * Write a final error message
      *
      * @param  \Symfony\Component\Console\Output\OutputInterface $out
-     * @param  \Exception                                        $e
+     * @param  \Throwable                                        $t
      * @return int
-     * @throws \Exception
+     * @throws \Throwable
      */
-    public function crash(OutputInterface $out, Exception $e): int
+    public function crash(OutputInterface $out, Throwable $t): int
     {
         if ($out->isDebug()) {
-            throw $e;
+            throw $t;
         }
 
-        $out->writeln('<fg=red>' . $e->getMessage() . '</>');
+        $out->writeln('<fg=red>' . $t->getMessage() . '</>');
         if ($out->isVerbose()) {
             $out->writeln(
-                '<comment>Error triggered in file:</comment> ' . $e->getFile() .
-                ' <comment>in line:</comment> ' . $e->getLine()
+                '<comment>Error triggered in file:</comment> ' . $t->getFile() .
+                ' <comment>in line:</comment> ' . $t->getLine()
             );
         }
         return 1;

src/Console/Command/Hook.php

@@ -12,7 +12,6 @@
 namespace CaptainHook\App\Console\Command;
 
 use CaptainHook\App\Config;
-use CaptainHook\App\Console\IOUtil;
 use CaptainHook\App\Hook\Util;
 use CaptainHook\App\Runner\Bootstrap\Util as BootstrapUtil;
 use RuntimeException;
@@ -98,8 +97,8 @@ protected function execute(InputInterface $input, OutputInterface $output): int
             $hook->run();
 
             return 0;
-        } catch (Throwable $e) {
-            return $this->crash($output, $e);
+        } catch (Throwable $t) {
+            return $this->crash($output, $t);
         }
     }
 

tests/unit/Console/Command/ConfigurationTest.php

@@ -16,6 +16,7 @@
 use Symfony\Component\Console\Input\ArrayInput;
 use Symfony\Component\Console\Output\NullOutput;
 use PHPUnit\Framework\TestCase;
+use Symfony\Component\Console\Output\OutputInterface;
 
 class ConfigurationTest extends TestCase
 {
@@ -39,4 +40,26 @@ public function testExecute(): void
 
         unlink($config);
     }
+
+    /**
+     * Tests Configure::run
+     *
+     * @throws \Exception
+     */
+    public function testConfigFailure(): void
+    {
+        $resolver  = new Resolver();
+        $config    = '/foo/bar/fiz/baz/config.json';
+        $input     = new ArrayInput(['--configuration' => $config]);
+        $output    = $this->getMockBuilder(OutputInterface::class)
+                          ->disableOriginalConstructor()
+                          ->getMock();
+        $output->method('isVerbose')->willReturn(true);
+
+        $configure = new Configuration($resolver);
+        $configure->setIO(new NullIO());
+        $code = $configure->run($input, $output);
+
+        $this->assertEquals(1, $code);
+    }
 }