fix(messaging): request all permissions regardless of the configured presentation options (#826)

* fix(messaging): request all permissions regardless of the configured presentation options

* wip

Author: robingenz

.changeset/quiet-files-pump.md

@@ -0,0 +1,5 @@
+---
+'@capacitor-firebase/messaging': patch
+---
+
+fix(ios): request all permissions regardless of the configured presentation options

packages/messaging/README.md

@@ -106,7 +106,7 @@ On iOS you can configure the way the push notifications are displayed when the a
 
 | Prop                      | Type                              | Description                                                                                                                                                                                                                                                                                                                                                                                                                                                                                       | Default                                  | Since |
 | ------------------------- | --------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ---------------------------------------- | ----- |
-| **`presentationOptions`** | <code>PresentationOption[]</code> | This is an array of strings you can combine. Possible values in the array are: - `badge`: badge count on the app icon is updated (default value) - `sound`: the device will ring/vibrate when the push notification is received - `alert`: the push notification is displayed in a native dialog - `criticalAlert`: the push notification is displayed in a native dialog and bypasses the mute switch An empty array can be provided if none of the options are desired. Only available for iOS. | <code>["badge", "sound", "alert"]</code> | 0.2.2 |
+| **`presentationOptions`** | <code>PresentationOption[]</code> | This is an array of strings you can combine. Possible values in the array are: - `badge`: badge count on the app icon is updated (default value) - `sound`: the device will ring/vibrate when the push notification is received - `alert`: the push notification is displayed in a native dialog - `criticalAlert`: the push notification is displayed in a native dialog and bypasses the mute switch An empty array can be provided if none of the options are desired. Only available for iOS. | <code>["alert", "badge", "sound"]</code> | 0.2.2 |
 
 ### Examples
 
@@ -116,7 +116,7 @@ In `capacitor.config.json`:
 {
   "plugins": {
     "FirebaseMessaging": {
-      "presentationOptions": ["badge", "sound", "alert"]
+      "presentationOptions": ["alert", "badge", "sound"]
     }
   }
 }
@@ -132,7 +132,7 @@ import { CapacitorConfig } from '@capacitor/cli';
 const config: CapacitorConfig = {
   plugins: {
     FirebaseMessaging: {
-      presentationOptions: ["badge", "sound", "alert"],
+      presentationOptions: ["alert", "badge", "sound"],
     },
   },
 };

packages/messaging/ios/Plugin/FirebaseMessaging.swift

@@ -23,19 +23,11 @@ import FirebaseCore
 
     public func requestPermissions(completion: @escaping (_ granted: Bool, _ error: Error?) -> Void) {
         var options = UNAuthorizationOptions()
-        self.config.presentationOptions.forEach { option in
-            switch option {
-            case "alert":
-                options.insert(.alert)
-            case "badge":
-                options.insert(.badge)
-            case "sound":
-                options.insert(.sound)
-            case "criticalAlert":
-                options.insert(.criticalAlert)
-            default:
-                print("Unrecogizned authorization option: \(option)")
-            }
+        options.insert(.alert)
+        options.insert(.badge)
+        options.insert(.sound)
+        if self.config.presentationOptions.contains("criticalAlert") {
+            options.insert(.criticalAlert)
         }
         UNUserNotificationCenter.current().requestAuthorization(options: options) { granted, error in
             completion(granted, error)

packages/messaging/src/definitions.ts

@@ -21,8 +21,8 @@ declare module '@capacitor/cli' {
        *
        * Only available for iOS.
        *
-       * @example ["badge", "sound", "alert"]
-       * @default ["badge", "sound", "alert"]
+       * @example ["alert", "badge", "sound"]
+       * @default ["alert", "badge", "sound"]
        * @since 0.2.2
        */
       presentationOptions: PresentationOption[];