Skip to content

Commit ad0922d

Browse files
authored
fix: training-integration uat by updating image (#68)
* Update PyTorchJob image according to upstream E2E tests. * Update registry from which PaddleJob image is pulled to follow upstream E2E tests. Closes canonical/bundle-kubeflow#894, canonical/bundle-kubeflow#910
1 parent 4ca5f8e commit ad0922d

File tree

1 file changed

+13
-6
lines changed

1 file changed

+13
-6
lines changed

tests/notebooks/training/training-integration.ipynb

+13-6
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,15 @@
66
"source": [
77
"# Test Training Operator Integration\n",
88
"\n",
9-
"This example notebook is loosely based on [this](https://github.com/kubeflow/training-operator/blob/master/sdk/python/examples/kubeflow-tfjob-sdk.ipynb) upstream example.\n",
9+
"This example notebook is loosely based on the following upstream examples:\n",
10+
"* [TFJob](https://github.com/kubeflow/training-operator/blob/964a6e836eedff11edfe79cc9f4e5b7c623cbe88/examples/tensorflow/image-classification/create-tfjob.ipynb)\n",
11+
"* [PyTorchJob](https://github.com/kubeflow/training-operator/blob/964a6e836eedff11edfe79cc9f4e5b7c623cbe88/examples/pytorch/image-classification/create-pytorchjob.ipynb)\n",
12+
"* [PaddleJob](https://github.com/kubeflow/training-operator/blob/964a6e836eedff11edfe79cc9f4e5b7c623cbe88/examples/paddlepaddle/simple-cpu.yaml)\n",
1013
"\n",
11-
"- create training job of type: TFJob, PyTorchJob, and PaddleJob\n",
14+
"Note that the above can get out of sync with the actual testing upstream does, so make sure to also check out [upstream E2E tests](https://github.com/kubeflow/training-operator/tree/964a6e836eedff11edfe79cc9f4e5b7c623cbe88/sdk/python/test/e2e) for updating the notebook.\n",
15+
"\n",
16+
"The workflow for each job (TFJob, PyTorchJob, and PaddleJob) is:\n",
17+
"- create training job\n",
1218
"- monitor its execution\n",
1319
"- get training logs\n",
1420
"- delete job"
@@ -142,7 +148,7 @@
142148
"source": [
143149
"### Define a TFJob\n",
144150
"\n",
145-
"Define a TFJob object before deploying it. This TFJob is similar to [this](https://github.com/kubeflow/training-operator/blob/master/sdk/python/examples/kubeflow-tfjob-sdk.ipynb) example."
151+
"Define a TFJob object before deploying it."
146152
]
147153
},
148154
{
@@ -411,7 +417,8 @@
411417
"source": [
412418
"PYTORCHJOB_NAME = \"pytorch-dist-mnist-gloo\"\n",
413419
"PYTORCHJOB_CONTAINER = \"pytorch\"\n",
414-
"PYTORCHJOB_IMAGE = \"gcr.io/kubeflow-ci/pytorch-dist-mnist-test:v1.0\""
420+
"PYTORCHJOB_IMAGE = \"kubeflow/pytorch-dist-mnist:v1-3a360ba\"\n",
421+
"# The image above should be updated with each release with the latest available in the registry."
415422
]
416423
},
417424
{
@@ -633,7 +640,7 @@
633640
"source": [
634641
"### Define a PaddleJob\n",
635642
"\n",
636-
"Define a PaddleJob object before deploying it. This PaddleJob is loosely based on [this](https://github.com/kubeflow/training-operator/blob/11b7a115e6538caeab405344af98f0d5b42a4c96/examples/paddlepaddle/simple-cpu.yaml) example."
643+
"Define a PaddleJob object before deploying it."
637644
]
638645
},
639646
{
@@ -644,7 +651,7 @@
644651
"source": [
645652
"PADDLEJOB_NAME = \"paddle-simple-cpu\"\n",
646653
"PADDLEJOB_CONTAINER = \"paddle\"\n",
647-
"PADDLEJOB_IMAGE = \"registry.baidubce.com/paddlepaddle/paddle:2.4.0rc0-cpu\""
654+
"PADDLEJOB_IMAGE = \"docker.io/paddlepaddle/paddle:2.4.0rc0-cpu\""
648655
]
649656
},
650657
{

0 commit comments

Comments
 (0)