Skip to content

Re-enable TCC for GHA CI #10832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
npepinpe opened this issue Oct 27, 2022 · 4 comments
Closed

Re-enable TCC for GHA CI #10832

npepinpe opened this issue Oct 27, 2022 · 4 comments
Assignees
Labels
area/build Marks an issue as related to our build pipeline (e.g. Maven settings, CI, etc.) kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc.

Comments

@npepinpe
Copy link
Member

Description

Since moving to our own self hosted runners with a DinD sibling, the actions controller adds an environment variable DOCKER_HOST which overrides the TCC agent settings, resulting in TCC being completely unused.

Possible solutions:

  • Unset the DOCKER_HOST environment variable in the job/workflow directly.
  • Disable the local DinD sibling on the actions runner directly.
@npepinpe npepinpe added the kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. label Oct 27, 2022
@npepinpe npepinpe self-assigned this Oct 28, 2022
@npepinpe npepinpe added the area/build Marks an issue as related to our build pipeline (e.g. Maven settings, CI, etc.) label Oct 28, 2022
@npepinpe
Copy link
Member Author

npepinpe commented Nov 1, 2022

We need the local DinD sibling right now to run a local registry in order to use camunda/zeebe:current-test with TCC. So the simplest solution is to unset the DOCKER_HOST environment variable for the step where we run the tests.

I'd like to time box another approach however, which is using Testcontainers to build the Docker image. This may also solve #7249. I'll timebox 3 hours tops (so until lunch), let's see.

@npepinpe
Copy link
Member Author

npepinpe commented Nov 1, 2022

It looks like we can't use our existing Dockerfile with the built-in ImageFromDockerFile from TC due to the following issue: testcontainers/testcontainers-java#3238

@npepinpe
Copy link
Member Author

npepinpe commented Nov 1, 2022

OK, so I think the final proposal would be to simply merge both containers, that way DOCKER_HOST is not defined anywhere, I think. I'll try this out and see what happens.

See https://github.com/actions-runner-controller/actions-runner-controller/blob/master/docs/detailed-docs.md#runner-with-dind

@npepinpe
Copy link
Member Author

npepinpe commented Nov 1, 2022

Seems to work well enough: https://github.com/camunda/zeebe/actions/runs/3371462996/jobs/5593807780

I would propose that we do this. It requires a few tweaks to the runner spec, but nothing to be done from the Zeebe side.

@npepinpe npepinpe closed this as completed Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Marks an issue as related to our build pipeline (e.g. Maven settings, CI, etc.) kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc.
Projects
None yet
Development

No branches or pull requests

1 participant