Skip to content

Commit a4f66c7

Browse files
authored
Merge pull request Expensify#60792 from daledah/fix/58351
fix: update title and url correctly when changing category name
2 parents 3e3247f + d32ec9b commit a4f66c7

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

src/pages/workspace/categories/CategorySettingsPage.tsx

+6-3
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import {useIsFocused} from '@react-navigation/native';
12
import React, {useEffect, useMemo, useState} from 'react';
23
import {View} from 'react-native';
34
import {useOnyx} from 'react-native-onyx';
@@ -45,7 +46,7 @@ function CategorySettingsPage({
4546
},
4647
navigation,
4748
}: CategorySettingsPageProps) {
48-
const [policyCategories] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY_CATEGORIES}${policyID}`);
49+
const [policyCategories] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY_CATEGORIES}${policyID}`, {canBeMissing: false});
4950
const styles = useThemeStyles();
5051
const {translate} = useLocalize();
5152
const [deleteCategoryConfirmModalVisible, setDeleteCategoryConfirmModalVisible] = useState(false);
@@ -62,12 +63,14 @@ function CategorySettingsPage({
6263
Navigation.goBack(isQuickSettingsFlow ? ROUTES.SETTINGS_CATEGORIES_ROOT.getRoute(policyID, backTo) : undefined);
6364
};
6465

66+
const isFocused = useIsFocused();
67+
6568
useEffect(() => {
66-
if (policyCategory?.name === categoryName || !policyCategory) {
69+
if (policyCategory?.name === categoryName || !isFocused) {
6770
return;
6871
}
6972
navigation.setParams({categoryName: policyCategory?.name});
70-
}, [categoryName, navigation, policyCategory]);
73+
}, [categoryName, navigation, policyCategory?.name, isFocused]);
7174

7275
const flagAmountsOverText = useMemo(() => {
7376
if (policyCategory?.maxExpenseAmount === CONST.DISABLED_MAX_EXPENSE_VALUE || !policyCategory?.maxExpenseAmount) {

0 commit comments

Comments
 (0)