tweak naming and other stuffs

Author: caiyue1993

Example/IceCream_Example/AppDelegate.swift

@@ -24,7 +24,7 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
             SyncObject(type: Cat.self),
             SyncObject(type: Person.self, uObjectClassType: Cat.self)
             ])
-      
+        
         /// If you wanna test public Database, comment the above syncEngine code and uncomment the following one
         /// Besides, uncomment Line 26 to 28 in Person.swift file
 //        syncEngine = SyncEngine(objects: [SyncObject<Person>()], databaseScope: .public)

Example/IceCream_Example/CatsViewController.swift

@@ -37,7 +37,6 @@ final class CatsViewController: UIViewController {
 
         view.addSubview(tableView)
         navigationItem.rightBarButtonItem = addBarItem
-        title = "Cats"
 
         bind()
     }

Example/IceCream_Example/Dog.swift

@@ -21,7 +21,7 @@ class Dog: Object {
     @objc dynamic var avatar: CreamAsset?
 
     // Relationships usage in Realm: https://realm.io/docs/swift/latest/#relationships
-//    @objc dynamic var owner: Person? // to-one relationships must be optional
+    @objc dynamic var owner: Person? // to-one relationships must be optional
 
     override class func primaryKey() -> String? {
         return "id"

Example/IceCream_Example/DogsViewController.swift

@@ -38,7 +38,6 @@ final class DogsViewController: UIViewController {
 
         view.addSubview(tableView)
         navigationItem.rightBarButtonItem = addBarItem
-        title = "Dogs"
 
         bind()
     }
@@ -67,7 +66,7 @@ final class DogsViewController: UIViewController {
         let dog = Dog()
         dog.name = "Dog Number " + "\(dogs.count)"
         dog.age = dogs.count + 1
-//        dog.owner = jim
+        dog.owner = jim
 
         let data = UIImage(named: dog.age % 2 == 1 ? "smile_dog" : "tongue_dog")!.jpegData(compressionQuality: 1.0)
         dog.avatar = CreamAsset.create(object: dog, propName: Dog.AVATAR_KEY, data: data!)
@@ -133,7 +132,7 @@ extension DogsViewController: UITableViewDataSource {
 
     public func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {
         let cell = tableView.dequeueReusableCell(withIdentifier: "cell")
-        cell?.textLabel?.text = dogs[indexPath.row].name + " Age: \(dogs[indexPath.row].age)"
+        cell?.textLabel?.text = dogs[indexPath.row].name + "\(dogs[indexPath.row].age)" + "owner: \(dogs[indexPath.row].owner?.name)"
         if let data = dogs[indexPath.row].avatar?.storedData() {
             cell?.imageView?.image = UIImage(data: data)
         } else {

Example/IceCream_Example/OwnersViewController.swift

@@ -36,7 +36,6 @@ final class OwnersViewController: UIViewController {
 
         view.addSubview(tableView)
         navigationItem.rightBarButtonItem = addBarItem
-        title = "Owners"
 
         bind()
     }

Example/IceCream_Example/TabBarViewController.swift

@@ -12,10 +12,18 @@ final class TabBarViewController: UITabBarController {
 
     override func viewDidLoad() {
         super.viewDidLoad()
-         viewControllers = [
-            UINavigationController(rootViewController: DogsViewController()),
-            UINavigationController(rootViewController: CatsViewController()),
-            UINavigationController(rootViewController: OwnersViewController())
+        
+        let dogsViewController = DogsViewController()
+        dogsViewController.title = "Dogs"
+        let catsViewController = CatsViewController()
+        catsViewController.title = "Cats"
+        let ownersViewController = OwnersViewController()
+        ownersViewController.title = "Owners"
+        
+        viewControllers = [
+            UINavigationController(rootViewController: dogsViewController),
+            UINavigationController(rootViewController: catsViewController),
+            UINavigationController(rootViewController: ownersViewController)
         ]
     }
 

IceCream/Classes/PendingRelationshipsWorker.swift

@@ -8,29 +8,26 @@
 import Foundation
 import RealmSwift
 
-final class PendingRelationshipsWorker<ListElement: Object> {
-    
-    private let listElementType: ListElement.Type
+final class PendingRelationshipsWorker<Element: Object> {
 
     var realm: Realm?
     var owner: Object?
 
     private var pendingListElementPrimaryKeyValue: [String: Any] = [:]
 
-    init(listElementType: ListElement.Type) {
-        self.listElementType = listElementType
-    }
-    
     func addToPendingListElement(propertyName: String, primaryKeyValue: Any) {
         pendingListElementPrimaryKeyValue[propertyName] = primaryKeyValue
     }
 
     func resolvePendingListElements() {
-        guard let owner = owner, let realm = realm, pendingListElementPrimaryKeyValue.count > 0 else { return }
+        guard let owner = owner, let realm = realm, pendingListElementPrimaryKeyValue.count > 0 else {
+            // Maybe we could add one log here
+            return
+        }
         BackgroundWorker.shared.start {
             for (propName, primaryKeyValue) in self.pendingListElementPrimaryKeyValue {
-                guard let list = owner.value(forKey: propName) as? List<ListElement> else { return }
-                if let existListElementObject = realm.object(ofType: self.listElementType, forPrimaryKey: primaryKeyValue) {
+                guard let list = owner.value(forKey: propName) as? List<Element> else { return }
+                if let existListElementObject = realm.object(ofType: Element.self, forPrimaryKey: primaryKeyValue) {
                     try! realm.write {
                         list.append(existListElementObject)
                     }

IceCream/Classes/SyncEngine.swift

@@ -26,7 +26,7 @@ public final class SyncEngine {
             let publicDatabaseManager = PublicDatabaseManager(objects: objects, container: container)
             self.init(databaseManager: publicDatabaseManager)
         default:
-            fatalError("Not supported yet")
+            fatalError("Shared database scope is not supported yet")
         }
     }
 

IceCream/Classes/SyncObject.swift

@@ -25,9 +25,9 @@ public final class SyncObject<T, U, V, W> where T: Object & CKRecordConvertible
 
     public let realmConfiguration: Realm.Configuration
 
-    private let pendingUTypeRelationshipsWorker = PendingRelationshipsWorker(listElementType: U.self)
-    private let pendingVTypeRelationshipsWorker = PendingRelationshipsWorker(listElementType: V.self)
-    private let pendingWTypeRelationshipsWorker = PendingRelationshipsWorker(listElementType: W.self)
+    private let pendingUTypeRelationshipsWorker = PendingRelationshipsWorker<U>()
+    private let pendingVTypeRelationshipsWorker = PendingRelationshipsWorker<V>()
+    private let pendingWTypeRelationshipsWorker = PendingRelationshipsWorker<W>()
 
     public init(
         realmConfiguration: Realm.Configuration = .defaultConfiguration,