proxy: delete req cookie if empty

jphines · jphines · commit df7c47b940d4 · 2019-01-18T16:20:48.000-05:00
diff --git a/internal/proxy/oauthproxy.go b/internal/proxy/oauthproxy.go
@@ -112,6 +112,14 @@ func deleteSSOCookieHeader(req *http.Request, cookieName string) {
 			headers = append(headers, cookie.String())
 		}
 	}
+
+	if len(headers) == 0 {
+		// there are no cookies other then session cookie so we delete the header entirely
+		req.Header.Del("Cookie")
+		return
+	}
+
+	// if there are other headers to keep, we reset them minues the session cookie
 	req.Header.Set("Cookie", strings.Join(headers, ";"))
 }
 

Original file line number	Diff line number	Diff line change
`@@ -112,6 +112,14 @@ func deleteSSOCookieHeader(req *http.Request, cookieName string) {`
`112`	`112`	`headers = append(headers, cookie.String())`
`113`	`113`	`}`
`114`	`114`	`}`
	`115`	`+`
	`116`	`+ if len(headers) == 0 {`
	`117`	`+ // there are no cookies other then session cookie so we delete the header entirely`
	`118`	`+ req.Header.Del("Cookie")`
	`119`	`+ return`
	`120`	`+ }`
	`121`	`+`
	`122`	`+ // if there are other headers to keep, we reset them minues the session cookie`
`115`	`123`	`req.Header.Set("Cookie", strings.Join(headers, ";"))`
`116`	`124`	`}`
`117`	`125`