this test was pulled in from a different branch and is unrelated

Author: Jusshersmith

internal/proxy/oauthproxy_test.go

@@ -1321,78 +1321,3 @@ func TestHTTPSRedirect(t *testing.T) {
 		})
 	}
 }
-
-// We want to test that allowed email addresses passed in
-// via the upstream config will override those in the environment.
-//func TestAllowedEmailAddressOverrides(t *testing.T) {
-//	testCases := []struct {
-//		name                      string
-//		environmentEmailAddresses string
-//		upstreamEmailAddresses    []string
-//		expectedStatusCode        int
-//	}{
-//		{
-//			name:                      "environmentEmailAddress set, upstreamEmailAddress unset",
-//			environmentEmailAddresses: "[email protected]",
-//			upstreamEmailAddresses:    nil,
-//			expectedStatusCode:        http.StatusOK,
-//		},
-//		{
-//			name:                      "environmentEmailAddress unset, upstreamEmailAddress set",
-//			environmentEmailAddresses: "",
-//			upstreamEmailAddresses:    []string{"[email protected]"},
-//			expectedStatusCode:        http.StatusOK,
-//		},
-//		{
-//			name:                      "environmentEmailAddress set, upstreamEmailAddress set",
-//			environmentEmailAddresses: "foo",
-//			upstreamEmailAddresses:    []string{"[email protected]"},
-///			expectedStatusCode:        http.StatusOK,
-//		},
-//		{
-//			name:                      "environmentEmailAddress unset, upstreamEmailAddress unset",
-//			environmentEmailAddresses: "",
-//			upstreamEmailAddresses:    nil,
-//			expectedStatusCode:        http.StatusForbidden,
-//		},
-//		{
-//			name:                      "environmentEmailAddress valid, upstreamEmailAddress invalid",
-//			environmentEmailAddresses: "[email protected]",
-//			upstreamEmailAddresses:    []string{"[email protected]"},
-//			expectedStatusCode:        http.StatusForbidden,
-///		},
-//	}
-
-//	for _, tc := range testCases {
-//		t.Run(tc.name, func(t *testing.T) {
-
-//			upstreamConfig := &UpstreamConfig{
-//				AllowedEmailAddresses: tc.upstreamEmailAddresses,
-//			}
-
-//			proxy, close := testNewOAuthProxy(t,
-//				setValidator(func(email string) bool {
-//					if email == tc.environmentEmailAddresses {
-//						return true
-//					}
-//					return false
-////////				}),
-////////				SetUpstreamConfig(upstreamConfig),
-//////			)
-//////			defer close()
-//////			t.Errorf("TESSSSSSSSSSSSSSSSSSST: %+v", proxy.upstreamConfig)
-
-//////			rec := httptest.NewRecorder()
-//////			req := httptest.NewRequest("GET", "https://localhost/", nil)
-//////			proxy.Handler().ServeHTTP(rec, req)
-//////			resp := rec.Result()
-
-//////			if tc.expectedStatusCode != resp.StatusCode {
-////				t.Errorf("have: %v", resp.StatusCode)
-//				t.Errorf("want: %v", tc.expectedStatusCode)
-//				t.Fatalf("unexpected status code returned")
-//			}
-//		})
-//
-//	}
-//}