Null pointer exception when validating embedded message with ReflectiveValidatorIndex

[dainiusfigoras]

Hi,

some of our proto messages have embedded messages, that looks something like this:

message TokenUse {
  message Payload {
    string token = 1;
  }
  Payload payload = 1;
}

but when running server validation (with ReflectiveValidatorIndex) it generates null pointer exception:

java.lang.NullPointerException: null
	at io.envoyproxy.pgv.ReflectiveValidatorIndex.lambda$reflectiveValidatorFor$1(ReflectiveValidatorIndex.java:39)

it's even more strange/disturbing because there is no validation conditions, so I would expect it to use ALWAYS_VALID (or something like that).

I think it happens because embedded message is translated to inner class (TokenUse$Payload) and reflector doesn't find (or generate) it.
And then

ValidatorImpl impl = (ValidatorImpl)validatorClass.getDeclaredMethod("validatorFor", Class.class).invoke((Object)null, clazz);

returns null and then impl.assertValid(proto, this); fails with null pointer.

[seime]

Were you able to reproduce this one @rmichela ?

[rmichela]

Yes.