Prealloc msgs in multierr.Error (#1209)

apocelipes · rodaine · web-flow · commit c220710fc5a6 · 2025-01-02T19:45:09.000Z
"msgs"'s length is known, preallocate it can save memories.

Co-authored-by: Chris Roche &lt;github@rodaine.com&gt;
diff --git a/templates/goshared/msg.go b/templates/goshared/msg.go
@@ -95,7 +95,7 @@ type {{ multierrname . }} []error
 
 // Error returns a concatenation of all the error messages it wraps.
 func (m {{ multierrname . }}) Error() string {
-	var msgs []string
+	msgs := make([]string, 0, len(m))
 	for _, err := range m {
 		msgs = append(msgs, err.Error())
 	}

Original file line number	Diff line number	Diff line change
`@@ -95,7 +95,7 @@ type {{ multierrname . }} []error`
`95`	`95`
`96`	`96`	`// Error returns a concatenation of all the error messages it wraps.`
`97`	`97`	`func (m {{ multierrname . }}) Error() string {`
`98`		`- var msgs []string`
	`98`	`+ msgs := make([]string, 0, len(m))`
`99`	`99`	`for _, err := range m {`
`100`	`100`	`msgs = append(msgs, err.Error())`
`101`	`101`	`}`