Skip to content

Commit 878a477

Browse files
authored
Fix check failure message on partial images (#3826)
1 parent c544d37 commit 878a477

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

private/bufpkg/bufcheck/client.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -118,8 +118,8 @@ func (c *client) Lint(
118118
logRulesConfig(c.logger, config.rulesConfig)
119119
files, err := descriptor.FileDescriptorsForProtoFileDescriptors(imageToProtoFileDescriptors(image))
120120
if err != nil {
121-
// If a validated Image results in an error, this is a system error.
122-
return syserror.Wrap(err)
121+
// An Image may be invalid if it does not contain all of the required dependencies.
122+
return fmt.Errorf("input image: %w", err)
123123
}
124124
request, err := check.NewRequest(
125125
files,
@@ -184,13 +184,13 @@ func (c *client) Breaking(
184184
logRulesConfig(c.logger, config.rulesConfig)
185185
fileDescriptors, err := descriptor.FileDescriptorsForProtoFileDescriptors(imageToProtoFileDescriptors(image))
186186
if err != nil {
187-
// If a validated Image results in an error, this is a system error.
188-
return syserror.Wrap(err)
187+
// An Image may be invalid if it does not contain all of the required dependencies.
188+
return fmt.Errorf("input image: %w", err)
189189
}
190190
againstFileDescriptors, err := descriptor.FileDescriptorsForProtoFileDescriptors(imageToProtoFileDescriptors(againstImage))
191191
if err != nil {
192-
// If a validated Image results in an error, this is a system error.
193-
return syserror.Wrap(err)
192+
// An Image may be invalid if it does not contain all of the required dependencies.
193+
return fmt.Errorf("against image: %w", err)
194194
}
195195
request, err := check.NewRequest(
196196
fileDescriptors,

0 commit comments

Comments
 (0)