Skip to content

Commit 2b30e18

Browse files
committed
Expand FIELD_CARDINALITY_SAME for optional cases
1 parent b0639c7 commit 2b30e18

File tree

3 files changed

+7
-0
lines changed

3 files changed

+7
-0
lines changed

private/bufpkg/bufcheck/breaking_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -231,6 +231,7 @@ func TestRunBreakingFieldSameCardinality(t *testing.T) {
231231
bufanalysistesting.NewFileAnnotation(t, "1.proto", 44, 5, 44, 20, "FIELD_SAME_CARDINALITY"),
232232
bufanalysistesting.NewFileAnnotation(t, "1.proto", 45, 5, 45, 19, "FIELD_SAME_CARDINALITY"),
233233
bufanalysistesting.NewFileAnnotation(t, "1.proto", 48, 5, 48, 19, "FIELD_SAME_CARDINALITY"),
234+
bufanalysistesting.NewFileAnnotation(t, "1.proto", 54, 5, 54, 30, "FIELD_SAME_CARDINALITY"),
234235
bufanalysistesting.NewFileAnnotation(t, "2.proto", 6, 3, 6, 26, "FIELD_SAME_CARDINALITY"),
235236
bufanalysistesting.NewFileAnnotation(t, "2.proto", 13, 3, 13, 26, "FIELD_SAME_CARDINALITY"),
236237
bufanalysistesting.NewFileAnnotation(t, "2.proto", 14, 3, 14, 24, "FIELD_SAME_CARDINALITY"),

private/bufpkg/bufcheck/testdata/breaking/current/breaking_field_same_cardinality/1.proto

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,5 +51,8 @@ message Three {
5151
repeated One four = 4;
5252
map<int32, int32> five = 5;
5353
map<int32, One> six = 6;
54+
optional int32 seven = 7;
55+
Eight eight = 8;
56+
optional Eight nine = 9;
5457
}
5558
}

private/bufpkg/bufcheck/testdata/breaking/previous/breaking_field_same_cardinality/1.proto

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,9 @@ message Three {
5454
repeated One four = 4;
5555
map<int32, int32> five = 5;
5656
map<int32, One> six = 6;
57+
int32 seven = 7;
58+
optional Eight eight = 8;
59+
Eight nine = 9;
5760
}
5861
}
5962

0 commit comments

Comments
 (0)