disable HTTP3 whenever protocol is grpc

sudorandom · sudorandom · commit 16547d8c58f4 · 2024-07-04T21:04:41.000+02:00
diff --git a/private/buf/cmd/buf/command/curl/curl.go b/private/buf/cmd/buf/command/curl/curl.go
@@ -519,6 +519,10 @@ func (f *flags) validate(isSecure bool) error {
 		return fmt.Errorf("--%s cannot be used with --%s", unixSocketFlagName, http3FlagName)
 	}
 
+	if f.Protocol == connect.ProtocolGRPC && f.HTTP3 {
+		return fmt.Errorf("--%s cannot be used with --%s=%s", http3FlagName, protocolFlagName, connect.ProtocolGRPC)
+	}
+
 	if f.Netrc && f.NetrcFile != "" {
 		return fmt.Errorf("--%s and --%s flags are mutually exclusive; they may not both be specified", netrcFlagName, netrcFileFlagName)
 	}

Original file line number	Diff line number	Diff line change
`@@ -519,6 +519,10 @@ func (f *flags) validate(isSecure bool) error {`
`519`	`519`	`return fmt.Errorf("--%s cannot be used with --%s", unixSocketFlagName, http3FlagName)`
`520`	`520`	`}`
`521`	`521`
	`522`	`+ if f.Protocol == connect.ProtocolGRPC && f.HTTP3 {`
	`523`	`+ return fmt.Errorf("--%s cannot be used with --%s=%s", http3FlagName, protocolFlagName, connect.ProtocolGRPC)`
	`524`	`+ }`
	`525`	`+`
`522`	`526`	`if f.Netrc && f.NetrcFile != "" {`
`523`	`527`	`return fmt.Errorf("--%s and --%s flags are mutually exclusive; they may not both be specified", netrcFlagName, netrcFileFlagName)`
`524`	`528`	`}`