Skip to content

feat: support webp format #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2022
Merged

feat: support webp format #343

merged 1 commit into from
Dec 5, 2022

Conversation

bubkoo
Copy link
Owner

@bubkoo bubkoo commented Dec 5, 2022 •
edited
Loading

add the webp property to the mimes object

re #326

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bubkoo
feat: support webp format
3634676 
add the `webp` property to the `mimes` object

re #326
accesslint[bot]
accesslint bot reviewed Dec 5, 2022
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

test/resources/webp/node.html
@@ -0,0 +1,3 @@
<div>
<img src="/base/test/resources/webp/image.webp" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative. This is a problem for people using screen readers.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

never mind

@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Base: 67.05% // Head: 67.05% // No change to project coverage 👍

Coverage data is based on head (3634676) compared to base (d9971a7).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #343   +/-   ##
=======================================
  Coverage   67.05%   67.05%           
=======================================
  Files          10       10           
  Lines         513      513           
  Branches      118      118           
=======================================
  Hits          344      344           
  Misses        120      120           
  Partials       49       49
Impacted Files Coverage Δ
src/mimes.ts 75.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bubkoo bubkoo merged commit 09d4810 into master Dec 5, 2022
@bubkoo bubkoo deleted the feat/webp branch December 5, 2022 07:02
github-actions bot pushed a commit that referenced this pull request Dec 5, 2022
chore(release): v1.11.0 [skip ci]
4446626 
# [1.11.0](v1.10.10...v1.11.0) (2022-12-05)

### Features

* support webp format ([#343](#343)) ([09d4810](09d4810)), closes [#326](#326)
@biiibooo
Copy link
Contributor

biiibooo bot commented Dec 5, 2022

🎉 This PR is included in version 1.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@biiibooo biiibooo bot added the released label Dec 5, 2022
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
@bubkoo @istaiti
feat: support webp format (bubkoo#343)
d103aab 
add the `webp` property to the `mimes` object

re bubkoo#326
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
@istaiti
chore(release): v1.11.0 [skip ci]
afb8242 
# [1.11.0](bubkoo/html-to-image@v1.10.10...v1.11.0) (2022-12-05)

### Features

* support webp format ([bubkoo#343](bubkoo#343)) ([09d4810](bubkoo@09d4810)), closes [bubkoo#326](bubkoo#326)
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
@bubkoo @istaiti
feat: support webp format (bubkoo#343)
e027be6 
add the `webp` property to the `mimes` object

re bubkoo#326
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
@istaiti
chore(release): v1.11.0 [skip ci]
ba0af80 
# [1.11.0](bubkoo/html-to-image@v1.10.10...v1.11.0) (2022-12-05)

### Features

* support webp format ([bubkoo#343](bubkoo#343)) ([09d4810](bubkoo@09d4810)), closes [bubkoo#326](bubkoo#326)
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
@bubkoo @istaiti
feat: support webp format (bubkoo#343)
645ef8c 
add the `webp` property to the `mimes` object

re bubkoo#326
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
@istaiti
chore(release): v1.11.0 [skip ci]
877c67e 
# [1.11.0](bubkoo/html-to-image@v1.10.10...v1.11.0) (2022-12-05)

### Features

* support webp format ([bubkoo#343](bubkoo#343)) ([09d4810](bubkoo@09d4810)), closes [bubkoo#326](bubkoo#326)
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
@bubkoo @istaiti
feat: support webp format (bubkoo#343)
aad30f7 
add the `webp` property to the `mimes` object

re bubkoo#326
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
@istaiti
chore(release): v1.11.0 [skip ci]
e2dbe25 
# [1.11.0](bubkoo/html-to-image@v1.10.10...v1.11.0) (2022-12-05)

### Features

* support webp format ([bubkoo#343](bubkoo#343)) ([09d4810](bubkoo@09d4810)), closes [bubkoo#326](bubkoo#326)
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
@bubkoo @istaiti
feat: support webp format (bubkoo#343)
7399503 
add the `webp` property to the `mimes` object

re bubkoo#326
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
@istaiti
chore(release): v1.11.0 [skip ci]
c9b10e1 
# [1.11.0](bubkoo/html-to-image@v1.10.10...v1.11.0) (2022-12-05)

### Features

* support webp format ([bubkoo#343](bubkoo#343)) ([09d4810](bubkoo@09d4810)), closes [bubkoo#326](bubkoo#326)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@accesslint accesslint[bot] accesslint[bot] left review comments

Assignees
No one assigned
Labels
PR(feature) PR: merged released size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bubkoo