Merge pull request #664 from markgrovs/fix-lock-sequence-crash

martijnpoppen · web-flow · commit 439763074542 · 2025-07-12T21:39:03.000+02:00
fix: Prevent crash in getLockSequenceNumber when devices is null
diff --git a/src/p2p/session.ts b/src/p2p/session.ts
@@ -2572,7 +2572,7 @@ export class P2PClientProtocol extends TypedEmitter<P2PClientProtocolEvents> {
         if (this.lockSeqNumber === -1) {
             let deviceType = undefined;
             let deviceSN = undefined;
-            if (this.rawStation?.devices !== undefined && this.rawStation?.devices.length > 0) {
+            if (this.rawStation?.devices?.length > 0) {
                 deviceType = this.rawStation?.devices[0]?.device_type;
                 deviceSN = this.rawStation?.devices[0]?.device_sn;
             }

Original file line number	Diff line number	Diff line change
`@@ -2572,7 +2572,7 @@ export class P2PClientProtocol extends TypedEmitter<P2PClientProtocolEvents> {`
`2572`	`2572`	`if (this.lockSeqNumber === -1) {`
`2573`	`2573`	`let deviceType = undefined;`
`2574`	`2574`	`let deviceSN = undefined;`
`2575`		`- if (this.rawStation?.devices !== undefined && this.rawStation?.devices.length > 0) {`
	`2575`	`+ if (this.rawStation?.devices?.length > 0) {`
`2576`	`2576`	`deviceType = this.rawStation?.devices[0]?.device_type;`
`2577`	`2577`	`deviceSN = this.rawStation?.devices[0]?.device_sn;`
`2578`	`2578`	`}`