Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

URL-like strings can cause empty autocomplete results #13718

Closed
rvagg opened this issue Apr 4, 2018 · 1 comment · Fixed by #13693
Closed

URL-like strings can cause empty autocomplete results #13718

rvagg opened this issue Apr 4, 2018 · 1 comment · Fixed by #13693
Labels
automated-tests feature/URLbar priority/P3 Major loss of function. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.23.x Release 5 ...

Comments

@rvagg
Copy link

rvagg commented Apr 4, 2018 •
edited by bsclifton
Loading

Test plan

See #13693

Description

foo and foo. are fine, foo.b and foo.bar is not, foo.bar. is fine again.

Steps to Reproduce

  1. Slowly type in github.com. to the urlbar
  2. Observe autocomplete up until github.c when you only get the "top sites" entry for github.com, not from your history
  3. It works again if you add a . on the end, i.e. github.com.

Brave Version

about:brave info:

Brave 0.22.13
V8 6.5.254.41
rev a8cfb16
Muon 5.1.2
OS Release 17.4.0
Update Channel Release
OS Architecture x64
OS Platform macOS
Node.js 7.9.0
Brave Sync v1.4.2
libchromiumcontent 65.0.3325.181

Same on a master build

Additional Information

Fixed in #13693 which also contains an explanation about why this happens.
@rvagg rvagg mentioned this issue Apr 4, 2018
Merged
@diracdeltas diracdeltas added priority/P3 Major loss of function. feature/URLbar labels Apr 4, 2018
@diracdeltas diracdeltas added this to the 0.24.x (Nightly Channel) milestone Apr 23, 2018
This was referenced Aug 14, 2018
Closed
Closed
Closed
@LaurenWags
Copy link
Member

LaurenWags commented Aug 14, 2018 •
edited by GeetaSarvadnya
Loading

Verified with macOS 10.12.6 using

  • 0.23.80 53a429f
  • Muon 8.0.8
  • libchromiumcontent 68.0.3440.84

Verified on Ubuntu 18 x64 with

  • 0.23.80 53a429f
  • Muon 8.0.8
  • libchromiumcontent 68.0.3440.84

Verified on Windows x64 with
• 0.23.80 53a429f
• Muon 8.0.8
• libchromiumcontent 68.0.3440.84

@kjozwiak kjozwiak mentioned this issue Aug 28, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
automated-tests feature/URLbar priority/P3 Major loss of function. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.23.x Release 5 (Release Channel)
Development

Successfully merging a pull request may close this issue.

Don't break up as URL for autocomplete if location bar text isn't a URL rvagg/browser-laptop
6 participants
@rvagg @diracdeltas @bsclifton @srirambv @LaurenWags @GeetaSarvadnya