Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Commit f0be763

Browse files
committed
Remove default browser check (and set on launch).
I believe this was causing a crash during end-to-end testing
1 parent 9b52daf commit f0be763

File tree

1 file changed

+0
-15
lines changed

1 file changed

+0
-15
lines changed

app/darwinInit.js

-15
Original file line numberDiff line numberDiff line change
@@ -55,15 +55,6 @@ if (process.platform === 'darwin') {
5555
return false
5656
}
5757

58-
const isDefaultBrowser = () => {
59-
try {
60-
const defaultProtocols = ['http', 'https']
61-
return defaultProtocols.every(p => app.isDefaultProtocolClient(p))
62-
} catch (e) {
63-
return false
64-
}
65-
}
66-
6758
const installBraveCore = () => {
6859
// get path to the bundled brave-core binary
6960
const installerPath = getBraveCoreInstallerPath()
@@ -111,12 +102,6 @@ if (process.platform === 'darwin') {
111102
// launch into freshly installed brave-core and append argument expected in:
112103
// https://github.com/brave/brave-browser/issues/1545
113104
let openCmd = `open -a "${installedPath}/${appName}/" --args --upgrade-from-muon`
114-
if (isDefaultBrowser()) {
115-
// if user has the Muon version of Brave as their default browser, let's
116-
// ask the user to make Brave Core their new default. Passing this extra
117-
// argument will prompt the user to ensure they agree with the choice
118-
openCmd += ' --make-default-browser'
119-
}
120105
console.log('Launching brave-core')
121106
execSync(openCmd)
122107
} catch (e) {

0 commit comments

Comments
 (0)