Always show the notification bar

per feedback in #15309 (comment)

Auditors: @diracdeltas

Author: bsclifton

app/updater.js

@@ -87,32 +87,18 @@ var scheduleUpdates = () => {
   }
 
   // Linux doesn't have an auto-update mechanism.
-  // Instead, deliver a periodic nag linking to instructions
-  if (isLinux() && appConfig.updates.deprecatedNagFrequency) {
-    electron.ipcMain.on(messages.NOTIFICATION_RESPONSE, (e, message, buttonIndex, persist) => {
-      appActions.hideNotification(message)
+  // Instead, show a persistent nag linking to instructions
+  if (isLinux()) {
+    appActions.showNotification({
+      buttons: [],
+      options: {
+        persist: false,
+        advancedText: 'See instructions to upgrade to the latest version',
+        advancedLink: 'https://brave-browser.readthedocs.io/en/latest/installing-brave.html#linux'
+      },
+      position: 'global',
+      message: 'This version of Brave is no longer supported and will not be updated.'
     })
-
-    const showDeprecationNotice = () => {
-      appActions.showNotification({
-        buttons: [
-          {text: 'OK'}
-        ],
-        options: {
-          persist: false,
-          advancedText: 'See instructions to upgrade to the latest version',
-          advancedLink: 'https://brave-browser.readthedocs.io/en/latest/installing-brave.html#linux'
-        },
-        position: 'global',
-        message: 'This version of Brave is no longer supported and will not be updated.'
-      })
-    }
-
-    setInterval(() => {
-      showDeprecationNotice()
-    }, appConfig.updates.deprecatedNagFrequency)
-
-    showDeprecationNotice()
   }
 
   // Startup check

js/constants/appConfig.js

@@ -109,8 +109,6 @@ module.exports = {
     partition: 'persist:tor'
   },
   updates: {
-    // (Linux only) display a deprecated warning every 10 minutes
-    deprecatedNagFrequency: 1000 * 10 * 60,
     // Check for front end updates every hour
     appUpdateCheckFrequency: 1000 * 60 * 60,
     // Check after 2 minutes, near startup