Skip to content

[ads] Sandbox ImageNTT assets to prevent path traversal #45770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tmancey opened this issue Apr 29, 2025 · 0 comments · May be fixed by brave/brave-core#28902
Open

[ads] Sandbox ImageNTT assets to prevent path traversal #45770

tmancey opened this issue Apr 29, 2025 · 0 comments · May be fixed by brave/brave-core#28902
Assignees
@tmancey
Labels
enhancement feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude

Comments

@tmancey
Copy link
Contributor

tmancey commented Apr 29, 2025 •
edited
Loading

Description

Sandbox ImageNTT in the same way as RichNTT (see the RichNTT implementation for reference). This will ensure that each campaign cannot reference another campaign or external source.
@tmancey tmancey self-assigned this Apr 29, 2025
@tmancey tmancey added this to Ads Apr 29, 2025
@github-project-automation github-project-automation bot moved this to New issues in Ads Apr 29, 2025
@tmancey tmancey moved this from New issues to Review in Ads Apr 29, 2025
@tmancey tmancey changed the title [ads] Sandbox ImageNTT [ads] Sandbox ImageNTT assets to prevent path traversal Apr 29, 2025
@tmancey tmancey moved this from Review to In progress in Ads Apr 29, 2025
@tmancey tmancey changed the title [ads] Sandbox ImageNTT assets to prevent path traversal [ads] ImageNTT code health Apr 30, 2025
@tmancey tmancey changed the title [ads] ImageNTT code health [ads] Sandbox ImageNTT assets to prevent path traversal[/-] Apr 30, 2025
@tmancey tmancey moved this from In progress to Review in Ads Apr 30, 2025
@tmancey tmancey changed the title [ads] Sandbox ImageNTT assets to prevent path traversal[/-] [ads] Sandbox ImageNTT assets to prevent path traversal Apr 30, 2025
@tmancey tmancey linked a pull request Apr 30, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
enhancement feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude
Projects
Ads
Status: Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ads] Sandbox ImageNTT assets to prevent path traversal brave/brave-core
1 participant
@tmancey