Adding CHECKs to all JSON string serialisation

For the types used by brave ads and ledger which we have to serialise,
it is possible to have failure, although we don't expect to see it. This
change adds a check to the result, so we may catch any cases in which it
might be taking place.

Author: cdesouza-chromium

vendor/bat-native-ads/src/bat/ads/ad_content_info.cc

@@ -5,6 +5,7 @@
 
 #include "bat/ads/ad_content_info.h"
 
+#include "base/check.h"
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
 #include "bat/ads/internal/base/logging_util.h"
@@ -137,7 +138,7 @@ bool AdContentInfo::FromValue(const base::Value::Dict& root) {
 
 std::string AdContentInfo::ToJson() const {
   std::string json;
-  base::JSONWriter::Write(ToValue(), &json);
+  CHECK(base::JSONWriter::Write(ToValue(), &json));
   return json;
 }
 

vendor/bat-native-ads/src/bat/ads/history_info.cc

@@ -5,6 +5,7 @@
 
 #include "bat/ads/history_info.h"
 
+#include "base/check.h"
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
 #include "bat/ads/history_item_info.h"
@@ -48,7 +49,7 @@ bool HistoryInfo::FromValue(const base::Value::Dict& root) {
 
 std::string HistoryInfo::ToJson() const {
   std::string json;
-  base::JSONWriter::Write(ToValue(), &json);
+  CHECK(base::JSONWriter::Write(ToValue(), &json));
   return json;
 }
 

vendor/bat-native-ads/src/bat/ads/inline_content_ad_info.cc

@@ -5,6 +5,7 @@
 
 #include "bat/ads/inline_content_ad_info.h"
 
+#include "base/check.h"
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
 #include "bat/ads/confirmation_type.h"
@@ -121,7 +122,7 @@ bool InlineContentAdInfo::FromValue(const base::Value::Dict& root) {
 
 std::string InlineContentAdInfo::ToJson() const {
   std::string json;
-  base::JSONWriter::Write(ToValue(), &json);
+  CHECK(base::JSONWriter::Write(ToValue(), &json));
   return json;
 }
 

vendor/bat-native-ads/src/bat/ads/internal/deprecated/client/client_info.cc

@@ -212,7 +212,7 @@ bool ClientInfo::FromValue(const base::Value::Dict& root) {
 
 std::string ClientInfo::ToJson() {
   std::string json;
-  base::JSONWriter::Write(ToValue(), &json);
+  CHECK(base::JSONWriter::Write(ToValue(), &json));
   return json;
 }
 

vendor/bat-native-ads/src/bat/ads/internal/deprecated/client/preferences/ad_preferences_info.cc

@@ -7,6 +7,7 @@
 
 #include <utility>
 
+#include "base/check.h"
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
 
@@ -129,7 +130,7 @@ bool AdPreferencesInfo::FromValue(const base::Value::Dict& root) {
 
 std::string AdPreferencesInfo::ToJson() const {
   std::string json;
-  base::JSONWriter::Write(ToValue(), &json);
+  CHECK(base::JSONWriter::Write(ToValue(), &json));
   return json;
 }
 

vendor/bat-native-ads/src/bat/ads/new_tab_page_ad_info.cc

@@ -7,6 +7,7 @@
 
 #include <tuple>
 
+#include "base/check.h"
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
 
@@ -156,7 +157,7 @@ bool NewTabPageAdInfo::FromValue(const base::Value::Dict& root) {
 
 std::string NewTabPageAdInfo::ToJson() const {
   std::string json;
-  base::JSONWriter::Write(ToValue(), &json);
+  CHECK(base::JSONWriter::Write(ToValue(), &json));
   return json;
 }
 

vendor/bat-native-ads/src/bat/ads/notification_ad_info.cc

@@ -94,7 +94,7 @@ bool NotificationAdInfo::FromValue(const base::Value::Dict& root) {
 
 std::string NotificationAdInfo::ToJson() const {
   std::string json;
-  base::JSONWriter::Write(ToValue(), &json);
+  CHECK(base::JSONWriter::Write(ToValue(), &json));
   return json;
 }
 

vendor/bat-native-ledger/src/bat/ledger/internal/legacy/client_properties.cc

@@ -7,6 +7,7 @@
 
 #include <utility>
 
+#include "base/check.h"
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
 #include "base/json/values_util.h"
@@ -173,7 +174,7 @@ bool ClientProperties::FromValue(const base::Value::Dict& dict) {
 
 std::string ClientProperties::ToJson() const {
   std::string json;
-  base::JSONWriter::Write(ToValue(), &json);
+  CHECK(base::JSONWriter::Write(ToValue(), &json));
   return json;
 }
 

vendor/bat-native-ledger/src/bat/ledger/internal/legacy/publisher_settings_properties.cc

@@ -7,6 +7,7 @@
 
 #include <utility>
 
+#include "base/check.h"
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
 #include "base/json/values_util.h"
@@ -188,7 +189,7 @@ bool PublisherSettingsProperties::FromValue(const base::Value::Dict& dict) {
 
 std::string PublisherSettingsProperties::ToJson() const {
   std::string json;
-  base::JSONWriter::Write(ToValue(), &json);
+  CHECK(base::JSONWriter::Write(ToValue(), &json));
   return json;
 }
 

vendor/bat-native-ledger/src/bat/ledger/internal/legacy/report_balance_properties.cc

@@ -5,6 +5,7 @@
 
 #include "bat/ledger/internal/legacy/report_balance_properties.h"
 
+#include "base/check.h"
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
 #include "base/logging.h"
@@ -134,7 +135,7 @@ bool ReportBalanceProperties::FromValue(const base::Value::Dict& dict) {
 
 std::string ReportBalanceProperties::ToJson() const {
   std::string json;
-  base::JSONWriter::Write(ToValue(), &json);
+  CHECK(base::JSONWriter::Write(ToValue(), &json));
   return json;
 }
 

vendor/bat-native-ledger/src/bat/ledger/internal/legacy/wallet_info_properties.cc

@@ -6,6 +6,7 @@
 #include "bat/ledger/internal/legacy/wallet_info_properties.h"
 
 #include "base/base64.h"
+#include "base/check.h"
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
 #include "base/logging.h"
@@ -94,7 +95,7 @@ bool WalletInfoProperties::FromValue(const base::Value::Dict& dict) {
 
 std::string WalletInfoProperties::ToJson() const {
   std::string json;
-  base::JSONWriter::Write(ToValue(), &json);
+  CHECK(base::JSONWriter::Write(ToValue(), &json));
   return json;
 }