Merge pull request #7809 from brave/pr7802_android_home_settings_tablet_1.20.x

kjozwiak · web-flow · commit b8bbe9bfda81 · 2021-02-04T00:44:11.000-05:00
[Android] Fixed homepage settings for tablets (uplift to 1.20.x)
diff --git a/android/java/org/chromium/chrome/browser/settings/BraveMainPreferencesBase.java b/android/java/org/chromium/chrome/browser/settings/BraveMainPreferencesBase.java
@@ -159,7 +159,7 @@ private void rearrangePreferenceOrders() {
         }
 
         // We don't have home button on top toolbar at the moment
-        if (!BottomToolbarConfiguration.isBottomToolbarEnabled()) {
+        if (!DeviceFormFactor.isTablet() && !BottomToolbarConfiguration.isBottomToolbarEnabled()) {
             removePreferenceIfPresent(PREF_HOMEPAGE);
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -159,7 +159,7 @@ private void rearrangePreferenceOrders() {`
`159`	`159`	`}`
`160`	`160`
`161`	`161`	`// We don't have home button on top toolbar at the moment`
`162`		`- if (!BottomToolbarConfiguration.isBottomToolbarEnabled()) {`
	`162`	`+ if (!DeviceFormFactor.isTablet() && !BottomToolbarConfiguration.isBottomToolbarEnabled()) {`
`163`	`163`	`removePreferenceIfPresent(PREF_HOMEPAGE);`
`164`	`164`	`}`
`165`	`165`	`}`