Merge pull request #19 from brave-intl/json_reader_crash

SergeyZhukovsky · web-flow · commit b88a4a1f06e8 · 2018-07-18T10:47:03.000-04:00
Fix for no unsignedTx object on reconcile
diff --git a/src/bat_helper.cc b/src/bat_helper.cc
@@ -1163,7 +1163,7 @@ namespace braveledger_bat_helper {
     bool error = d.HasParseError();
     if (false == error)
     {
-      error = !(d["unsignedTx"].IsObject());
+      error = !d.HasMember("unsignedTx") || !(d["unsignedTx"].IsObject());
     }
 
     if (false == error)

Original file line number	Diff line number	Diff line change
`@@ -1163,7 +1163,7 @@ namespace braveledger_bat_helper {`
`1163`	`1163`	`bool error = d.HasParseError();`
`1164`	`1164`	`if (false == error)`
`1165`	`1165`	`{`
`1166`		`- error = !(d["unsignedTx"].IsObject());`
	`1166`	`+ error = !d.HasMember("unsignedTx") \|\| !(d["unsignedTx"].IsObject());`
`1167`	`1167`	`}`
`1168`	`1168`
`1169`	`1169`	`if (false == error)`