Skip to content

Commit ac28907

Browse files
cdesouza-chromiummkarolin
authored andcommitted
[cr137] [Android] Moved click/longClick listeners for bookmark and saveOffline buttons to location bar classes
We still properly handle these events in BraveToolbarLayoutImpl, so no changes are required on our side. Chromium changes: https://chromium.googlesource.com/chromium/src/+/a3b80168e9abfa063071cc10ab487300c708856f commit a3b80168e9abfa063071cc10ab487300c708856f Author: Sirisha Kavuluru <[email protected]> Date: Tue Apr 15 12:25:20 2025 -0700 [Toolbar] Moved click/longClick listeners for bookmark and saveOffline buttons to location bar classes. * Moved onLongClick for saveOffline and bookmark button to LocationBarLayoutTablet since this has simple implementation. * Moved onClick for saveOffline and bookmark button to LocationBarCoordinator Change-Id: I4b97d9209fd04f761e93fe393efe7e0d10f6e0b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6448504 Reviewed-by: Patrick Noland <[email protected]> Reviewed-by: Theresa Sullivan <[email protected]> Commit-Queue: Sirisha Kavuluru <[email protected]> Reviewed-by: Ted Choc <[email protected]> Cr-Commit-Position: refs/heads/main@{#1447296}
1 parent 2283c95 commit ac28907

1 file changed

+2
-15
lines changed

patches/chrome-browser-ui-android-toolbar-java-src-org-chromium-chrome-browser-toolbar-top-ToolbarTablet.java.patch

+2-15
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,8 @@
11
diff --git a/chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarTablet.java b/chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarTablet.java
2-
index a64b322cdfdc1ecf69bc7abb0b7252c0b57c70c9..777de8473a4290e94c846977bbcd43e16d36d1eb 100644
2+
index a0b9117595eda6ce5fd0f2b410b67c67d0a9aeca..d3f1e58bbc4d5b755aaa7c0771ceedd0ed6a3d2e 100644
33
--- a/chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarTablet.java
44
+++ b/chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarTablet.java
5-
@@ -327,10 +327,12 @@ public class ToolbarTablet extends ToolbarLayout
6-
getContext(), getToolbarDataProvider().getTab(), /* fromAppMenu= */ false);
7-
RecordUserAction.record("MobileToolbarDownloadPage");
8-
}
9-
+ BraveToolbarLayout.class.cast(this).onClickImpl(v);
10-
}
11-
12-
@Override
13-
public boolean onLongClick(View v) {
14-
+ if (BraveToolbarLayout.class.cast(this).onLongClickImpl(v)) return true;
15-
String description = null;
16-
Context context = getContext();
17-
Resources resources = context.getResources();
18-
@@ -451,6 +453,7 @@ public class ToolbarTablet extends ToolbarLayout
5+
@@ -305,6 +305,7 @@ public class ToolbarTablet extends ToolbarLayout implements OnClickListener {
196
mLocationBar.getTabletCoordinator().tintBackground(textBoxColor);
207
mLocationBar.updateVisualsForState();
218
setToolbarHairlineColor(color);

0 commit comments

Comments
 (0)