Skip to content

Commit 99220df

Browse files
authored
Merge pull request #19756 from brave/remove-enable-filter-lists-dchecks
replace dchecks in EnableFilterList with conditional early returns
2 parents f56d89d + 07c72ac commit 99220df

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

components/brave_shields/browser/ad_block_regional_service_manager.cc

+9-3
Original file line numberDiff line numberDiff line change
@@ -233,18 +233,24 @@ void AdBlockRegionalServiceManager::EnableFilterList(const std::string& uuid,
233233
auto catalog_entry =
234234
brave_shields::FindAdBlockFilterListByUUID(filter_list_catalog_, uuid);
235235

236+
if (catalog_entry == filter_list_catalog_.end()) {
237+
return;
238+
}
236239
// Enable or disable the specified filter list
237-
DCHECK(catalog_entry != filter_list_catalog_.end());
238240
auto it = regional_filters_providers_.find(uuid);
239241
if (enabled) {
240-
DCHECK(it == regional_filters_providers_.end());
242+
if (it != regional_filters_providers_.end()) {
243+
return;
244+
}
241245
auto regional_filters_provider =
242246
std::make_unique<AdBlockComponentFiltersProvider>(
243247
component_update_service_, *catalog_entry, false);
244248
regional_filters_providers_.insert(
245249
{uuid, std::move(regional_filters_provider)});
246250
} else {
247-
DCHECK(it != regional_filters_providers_.end());
251+
if (it == regional_filters_providers_.end()) {
252+
return;
253+
}
248254
it->second->UnregisterComponent();
249255
regional_filters_providers_.erase(it);
250256
}

0 commit comments

Comments
 (0)