Merge pull request #8767 from brave/ksmith-hide-oauth-request

zenparsing · web-flow · commit 813b7186ae25 · 2021-05-12T13:51:27.000-04:00
Do not log request details for rewards external wallet session endpoints
diff --git a/vendor/bat-native-ledger/src/bat/ledger/internal/endpoint/bitflyer/post_oauth/post_oauth_bitflyer.cc b/vendor/bat-native-ledger/src/bat/ledger/internal/endpoint/bitflyer/post_oauth/post_oauth_bitflyer.cc
@@ -127,6 +127,7 @@ void PostOauth::Request(const std::string& external_account_id,
   request->headers = RequestAuthorization();
   request->content_type = "application/json";
   request->method = type::UrlMethod::POST;
+  request->skip_log = true;
   ledger_->LoadURL(std::move(request), url_callback);
 }
 
diff --git a/vendor/bat-native-ledger/src/bat/ledger/internal/endpoint/uphold/post_oauth/post_oauth.cc b/vendor/bat-native-ledger/src/bat/ledger/internal/endpoint/uphold/post_oauth/post_oauth.cc
@@ -92,6 +92,7 @@ void PostOauth::Request(
   request->headers = RequestAuthorization();
   request->content_type = "application/x-www-form-urlencoded";
   request->method = type::UrlMethod::POST;
+  request->skip_log = true;
   ledger_->LoadURL(std::move(request), url_callback);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -127,6 +127,7 @@ void PostOauth::Request(const std::string& external_account_id,`
`127`	`127`	`request->headers = RequestAuthorization();`
`128`	`128`	`request->content_type = "application/json";`
`129`	`129`	`request->method = type::UrlMethod::POST;`
	`130`	`+ request->skip_log = true;`
`130`	`131`	`ledger_->LoadURL(std::move(request), url_callback);`
`131`	`132`	`}`
`132`	`133`
Original file line number	Diff line number	Diff line change
`@@ -92,6 +92,7 @@ void PostOauth::Request(`
`92`	`92`	`request->headers = RequestAuthorization();`
`93`	`93`	`request->content_type = "application/x-www-form-urlencoded";`
`94`	`94`	`request->method = type::UrlMethod::POST;`
	`95`	`+ request->skip_log = true;`
`95`	`96`	`ledger_->LoadURL(std::move(request), url_callback);`
`96`	`97`	`}`
`97`	`98`