Skip to content

Commit 5b460bf

Browse files
authored
Merge pull request #395 from brave/overwrite_chromium_image_resources
Overwrite chrome/app/theme/chromium resources with ours
2 parents 98bff20 + 001e48b commit 5b460bf

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

build/commands/lib/updatePatches.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ const updatePatches = (options) => {
1616
let modifiedDiff = util.run('git', modifiedDiffArgs, runOptions)
1717
let moddedFileList = modifiedDiff.stdout.toString()
1818
.split('\n')
19-
.filter(s => s.length > 0 && !s.endsWith('.xtb'))
19+
.filter(s => s.length > 0 && !s.endsWith('.xtb') && !s.endsWith('.png'))
2020

2121
let n = moddedFileList.length
2222

build/commands/lib/util.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,9 @@ const util = {
6464
fs.copySync(path.join(braveAppDir, 'theme', 'brave'), path.join(chromeAppDir, 'theme', 'brave'))
6565
fs.copySync(path.join(braveAppDir, 'theme', 'default_100_percent', 'brave'), path.join(chromeAppDir, 'theme', 'default_100_percent', 'brave'))
6666
fs.copySync(path.join(braveAppDir, 'theme', 'default_200_percent', 'brave'), path.join(chromeAppDir, 'theme', 'default_200_percent', 'brave'))
67+
// By overwriting, we don't need to modify some grd files.
68+
fs.copySync(path.join(braveAppDir, 'theme', 'default_100_percent', 'brave'), path.join(chromeAppDir, 'theme', 'default_100_percent', 'chromium'))
69+
fs.copySync(path.join(braveAppDir, 'theme', 'default_200_percent', 'brave'), path.join(chromeAppDir, 'theme', 'default_200_percent', 'chromium'))
6770
fs.copySync(path.join(braveAppDir, 'vector_icons', 'brave'), path.join(chromeAppDir, 'vector_icons', 'brave'))
6871
// Copy XTB files for app/brave_strings.grd => chromium_strings.grd
6972
fs.copySync(path.join(braveAppDir, 'resources'), path.join(chromeAppDir, 'resources'))

0 commit comments

Comments
 (0)