Skip to content

Commit 48de4e4

Browse files
committed
Merge pull request #4443 from brave/simon-snpt-issue-7946
Store components data with unique folder
1 parent 130d844 commit 48de4e4

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

components/ntp_sponsored_images/browser/ntp_sponsored_images_component_installer.cc

+4-3
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ using brave_component_updater::BraveOnDemandUpdater;
2424
namespace {
2525

2626
constexpr char kNTPSponsoredImagesDisplayName[] = "NTP sponsored images";
27-
constexpr char kNTPSponsoredImagesBaseDirectory[] = "NTPSponsoredImages";
2827
constexpr size_t kHashSize = 32;
2928

3029
class NTPSponsoredImagesComponentInstallerPolicy
@@ -54,6 +53,7 @@ class NTPSponsoredImagesComponentInstallerPolicy
5453
std::vector<std::string> GetMimeTypes() const override;
5554

5655
private:
56+
const std::string component_id_;
5757
OnComponentReadyCallback ready_callback_;
5858
uint8_t component_hash_[kHashSize];
5959

@@ -63,7 +63,8 @@ class NTPSponsoredImagesComponentInstallerPolicy
6363
NTPSponsoredImagesComponentInstallerPolicy::
6464
NTPSponsoredImagesComponentInstallerPolicy(
6565
const RegionalComponentData& data, OnComponentReadyCallback callback)
66-
: ready_callback_(callback) {
66+
: component_id_(data.component_id),
67+
ready_callback_(callback) {
6768
// Generate hash from public key.
6869
std::string decoded_public_key;
6970
base::Base64Decode(data.component_base64_public_key, &decoded_public_key);
@@ -107,7 +108,7 @@ bool NTPSponsoredImagesComponentInstallerPolicy::VerifyInstallation(
107108

108109
base::FilePath NTPSponsoredImagesComponentInstallerPolicy::
109110
GetRelativeInstallDir() const {
110-
return base::FilePath::FromUTF8Unsafe(kNTPSponsoredImagesBaseDirectory);
111+
return base::FilePath::FromUTF8Unsafe(component_id_);
111112
}
112113

113114
void NTPSponsoredImagesComponentInstallerPolicy::GetHash(

0 commit comments

Comments
 (0)