Skip to content

Commit 421a75e

Browse files
authored
Merge pull request #12727 from brave/pr12694_bug/de-amp-toggle_1.38.x
Fix phantom de-amp toggle (uplift to 1.38.x)
2 parents e17638e + ac5fab7 commit 421a75e

File tree

2 files changed

+6
-11
lines changed

2 files changed

+6
-11
lines changed

browser/resources/settings/brave_overrides/privacy_page.js

-11
Original file line numberDiff line numberDiff line change
@@ -36,17 +36,6 @@ RegisterPolymerTemplateModifications({
3636
</settings-subpage>
3737
</template>
3838
`)
39-
const isDeAmpFeatureEnabled = loadTimeData.getBoolean('isDeAmpFeatureEnabled')
40-
if (isDeAmpFeatureEnabled) {
41-
pages.insertAdjacentHTML("afterend", `
42-
<settings-toggle-button
43-
class="hr"
44-
pref="{{prefs.brave.de_amp.enabled}}"
45-
label="${I18nBehavior.i18n("deAmpSettingLabel")}"
46-
sub-label="${I18nBehavior.i18n("deAmpSettingSubLabel")}">
47-
</settings-toggle-button>
48-
`);
49-
}
5039
const isNativeBraveWalletEnabled = loadTimeData.getBoolean('isNativeBraveWalletFeatureEnabled')
5140
if (isNativeBraveWalletEnabled) {
5241
pages.insertAdjacentHTML('beforeend', `

browser/resources/settings/brave_privacy_page/brave_personalization_options.html

+6
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,12 @@
5454
sub-label="$i18n{statsUsagePingEnabledDesc}"
5555
on-settings-boolean-control-change="onStatsUsagePingEnabledChange_">
5656
</settings-toggle-button>
57+
<settings-toggle-button
58+
class="cr-row"
59+
pref="{{prefs.brave.de_amp.enabled}}"
60+
label="$i18n{deAmpSettingLabel}"
61+
sub-label="$i18n{deAmpSettingSubLabel}">
62+
</settings-toggle-button>
5763
</template>
5864
<script src="brave_personalization_options.js"></script>
5965
</dom-module>

0 commit comments

Comments
 (0)