Skip to content

Commit 3b97a2b

Browse files
committed
[Win] Temporarily run browser tests with --disable-gpu-sandbox.
Browser tests error out on Windows CI with content/public/test/test_utils.cc(137): error: Failed RunLoop::Run() timed out. Timeout set at ProxyRunTestOnMainThreadLoop@content/public/test/browser_test_base.cc:800. Running with --disable-gpu avoids the error, but causes various WebGL tests to fail. Running with --no-sandbox avoids the error. Running with --disable-gpu-sandbox also avoids the error - picked this one is the least bad from the 2 above. It is not clear ATM what's causing the error. Only adds the flag on Windows in Release config.
1 parent 2eea2b3 commit 3b97a2b

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

build/commands/lib/test.js

+10
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,16 @@ const test = (passthroughArgs, suite, buildConfig = config.defaultBuildConfig, o
2828
'--enable-logging=stderr'
2929
]
3030

31+
// Cr93: browser tests error out on Windows CI with
32+
// content/public/test/test_utils.cc(137): error: Failed
33+
// RunLoop::Run() timed out. Timeout set at ProxyRunTestOnMainThreadLoop@
34+
// content/public/test/browser_test_base.cc:800.
35+
// Running with --disable-gpu-sandbox fixes it, but it's unclear ATM what the
36+
// issue is.
37+
if (suite === 'brave_browser_tests' && process.platform === 'win32' && buildConfig === 'Release') {
38+
braveArgs.push('--disable-gpu-sandbox')
39+
}
40+
3141
// Android doesn't support --v
3242
if (config.targetOS !== 'android') {
3343
braveArgs.push('--v=' + options.v)

0 commit comments

Comments
 (0)