Skip to content

Commit 37623df

Browse files
committed
Remove obsolete and incomplete license file generation
There is no real indication in the git history as to why this was added back in February 2018, but I suspect it was ported over from the muon browser.
1 parent a29b3f3 commit 37623df

File tree

1 file changed

+3
-50
lines changed

1 file changed

+3
-50
lines changed

BUILD.gn

+3-50
Original file line numberDiff line numberDiff line change
@@ -295,41 +295,6 @@ if (!is_mac && !is_android && !is_ios) {
295295
}
296296
}
297297

298-
action("generate_chromium_licenses") {
299-
license_file = "$root_gen_dir/LICENSES.chromium.html"
300-
301-
script = "//tools/licenses.py"
302-
303-
inputs = [
304-
rebase_path("//brave/resources/about_credits.tmpl"),
305-
rebase_path("//brave/resources/about_credits_entry.tmpl"),
306-
]
307-
308-
outputs = [
309-
license_file
310-
]
311-
312-
args = [
313-
"--target-os=$target_os",
314-
"credits",
315-
rebase_path(license_file, root_build_dir),
316-
]
317-
}
318-
319-
copy("brave_license_dist_resources") {
320-
sources = get_target_outputs(":generate_chromium_licenses")
321-
sources += [
322-
"//brave/LICENSE",
323-
]
324-
deps = [
325-
":generate_chromium_licenses",
326-
]
327-
328-
outputs = [
329-
"$brave_dist_dir/{{source_file_part}}"
330-
]
331-
}
332-
333298
process_version("generate_version") {
334299
template_file = "version.version"
335300
extra_args = [ "-e", "BRAVE_BROWSER_VERSION=\"$brave_version\"" ]
@@ -344,7 +309,6 @@ if (!is_android && !is_ios) {
344309
deps = [
345310
":brave",
346311
":generate_version",
347-
":brave_license_dist_resources",
348312
":packed_resources",
349313
"build/$target_os:brave",
350314
"//chrome:packed_resources",
@@ -392,20 +356,13 @@ action("create_symbols_dist") {
392356

393357
script = "//brave/script/create-dist.py"
394358

395-
inputs = get_target_outputs(":brave_license_dist_resources")
396359
dir_inputs = [ "$brave_project_name.breakpad.syms" ]
397360

398-
file_inputs = []
399-
foreach(input, inputs) {
400-
file_inputs += [ rebase_path(input, brave_dist_dir) ]
401-
}
402-
403361
rebase_output = rebase_path(output)
404362
rebase_base_dir = rebase_path(brave_dist_dir)
405363

406364
args = [
407365
"--base-dir=$rebase_base_dir",
408-
"--inputs=$file_inputs",
409366
"--dir-inputs=$dir_inputs",
410367
"--output=$rebase_output",
411368
]
@@ -414,7 +371,6 @@ action("create_symbols_dist") {
414371

415372
deps = [
416373
"app/$current_os:symbol_dist_resources",
417-
":brave_license_dist_resources",
418374
]
419375
}
420376

@@ -423,7 +379,7 @@ action("create_dist_zips") {
423379

424380
script = "//brave/script/create-dist.py"
425381

426-
inputs = get_target_outputs(":brave_license_dist_resources")
382+
inputs = []
427383

428384
if (!is_mac && !is_android && !is_ios) {
429385
inputs += get_target_outputs(":brave_dist_resources")
@@ -444,11 +400,9 @@ action("create_dist_zips") {
444400
]
445401
}
446402

447-
dist_dir = brave_dist_dir
448-
449403
file_inputs = []
450404
foreach(input, inputs) {
451-
file_inputs += [ rebase_path(input, dist_dir) ]
405+
file_inputs += [ rebase_path(input, brave_dist_dir) ]
452406
}
453407

454408
dir_inputs = []
@@ -464,7 +418,6 @@ action("create_dist_zips") {
464418

465419
deps = [
466420
":create_symbols_dist",
467-
":brave_license_dist_resources",
468421
"app/$current_os:dist_resources",
469422
]
470423

@@ -485,7 +438,7 @@ action("create_dist_zips") {
485438
if (is_mac) {
486439
rebase_base_dir = rebase_path(root_out_dir)
487440
} else {
488-
rebase_base_dir = rebase_path(dist_dir, root_out_dir)
441+
rebase_base_dir = rebase_path(brave_dist_dir, root_out_dir)
489442
}
490443
args = [
491444
"--base-dir=$rebase_base_dir",

0 commit comments

Comments
 (0)