Skip to content

Commit 29f828b

Browse files
committed
Temporarily disables WindowClosingConfirmBrowserTest.TestWithDownload on MacOS.
The test fails because in Chromium Private/Incognito profiles now ignore the "Ask for download location" setting and always prompt for the location. We will fix that in brave/brave-browser#29823, but until then let's disable this test on MacOS.
1 parent 07001f7 commit 29f828b

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

browser/ui/window_closing_confirm_browsertest.cc

+9-1
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,15 @@ IN_PROC_BROWSER_TEST_F(WindowClosingConfirmBrowserTest,
265265
ui_test_utils::WaitForBrowserToClose(brave_browser);
266266
}
267267

268-
IN_PROC_BROWSER_TEST_F(WindowClosingConfirmBrowserTest, TestWithDownload) {
268+
// Temporarily disable the test on MacOS until
269+
// https://github.com/brave/brave-browser/issues/29823 is fixed.
270+
#if BUILDFLAG(IS_MAC)
271+
#define MAYBE_TestWithDownload DISABLED_TestWithDownload
272+
#else
273+
#define MAYBE_TestWithDownload TestWithDownload
274+
#endif
275+
IN_PROC_BROWSER_TEST_F(WindowClosingConfirmBrowserTest,
276+
MAYBE_TestWithDownload) {
269277
// On macOS, download in-progress warning is not shown for normal profile window
270278
// closing as it can still continue after window is closed.
271279
// However, private profile window works like normal window of other platforms.

0 commit comments

Comments
 (0)