Merge pull request #247 from brave/version-gen-2

bbondy · web-flow · commit 0daf6a006aae · 2018-07-12T00:32:13.000-04:00
Fix dep for generating version
diff --git a/browser/BUILD.gn b/browser/BUILD.gn
@@ -49,6 +49,7 @@ source_set("browser_process") {
   ]
 
   deps = [
+    "//brave:generate_version",
     "//brave/browser/payments",
     "//brave/components/brave_shields/browser:brave_shields",
     "//brave/components/content_settings/core/browser",
diff --git a/script/version.py b/script/version.py
@@ -32,8 +32,6 @@ def create_version(target_gen_dir):
     version = get_brave_version()[1:]
     version_h_file.write(''.join(['#define BRAVE_BROWSER_VERSION "', version, '"']))
 
-  print("version_path is: ", version_path, get_brave_version())
-
 
 if __name__ == '__main__':
   sys.exit(main())

Original file line number	Diff line number	Diff line change
`@@ -49,6 +49,7 @@ source_set("browser_process") {`
`49`	`49`	`]`
`50`	`50`
`51`	`51`	`deps = [`
	`52`	`+ "//brave:generate_version",`
`52`	`53`	`"//brave/browser/payments",`
`53`	`54`	`"//brave/components/brave_shields/browser:brave_shields",`
`54`	`55`	`"//brave/components/content_settings/core/browser",`