Skip to content

Commit 067fbc8

Browse files
[cr138] AggregationService::SendReport deleted
These functions were being stubbed off, however they are now deleted, and therefore these stubs ought to be removed. Chromium changes: https://chromium.googlesource.com/chromium/src/+/51abbff317d68b58799cf77daa68971091022978 commit 51abbff317d68b58799cf77daa68971091022978 Author: Nan Lin <[email protected]> Date: Fri May 9 08:34:48 2025 -0700 Remove AggregationService::SendReport This public interface is never used on production. Change-Id: I0abb46ae9f33a85346daf76f9cd2c88a6976246b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6525828 Reviewed-by: Alex Turner <[email protected]> Commit-Queue: Nan Lin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1458125}
1 parent ced739d commit 067fbc8

File tree

2 files changed

+0
-26
lines changed

2 files changed

+0
-26
lines changed

chromium_src/content/browser/aggregation_service/aggregation_service_impl.cc

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -65,22 +65,6 @@ void AggregationServiceImpl::AssembleReport(
6565
AggregatableReportRequest report_request,
6666
AssemblyCallback callback) {}
6767

68-
void AggregationServiceImpl::SendReport(
69-
const GURL url,
70-
const AggregatableReport& report,
71-
std::optional<AggregatableReportRequest::DelayType> delay_type,
72-
SendCallback callback) {
73-
std::move(callback).Run(AggregatableReportSender::RequestStatus::kOk);
74-
}
75-
76-
void AggregationServiceImpl::SendReport(
77-
const GURL url,
78-
const base::Value& contents,
79-
std::optional<AggregatableReportRequest::DelayType> delay_type,
80-
SendCallback callback) {
81-
std::move(callback).Run(AggregatableReportSender::RequestStatus::kOk);
82-
}
83-
8468
const base::SequenceBound<AggregationServiceStorage>&
8569
AggregationServiceImpl::GetStorage() {
8670
return storage_;

chromium_src/content/browser/aggregation_service/aggregation_service_impl.h

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -72,16 +72,6 @@ class CONTENT_EXPORT AggregationServiceImpl
7272
// AggregationService:
7373
void AssembleReport(AggregatableReportRequest report_request,
7474
AssemblyCallback callback) override;
75-
void SendReport(
76-
const GURL url,
77-
const AggregatableReport& report,
78-
std::optional<AggregatableReportRequest::DelayType> delay_type,
79-
SendCallback callback) override;
80-
void SendReport(
81-
const GURL url,
82-
const base::Value& contents,
83-
std::optional<AggregatableReportRequest::DelayType> delay_type,
84-
SendCallback callback) override;
8575
void ClearData(base::Time delete_begin,
8676
base::Time delete_end,
8777
StoragePartition::StorageKeyMatcherFunction filter,

0 commit comments

Comments
 (0)