Skip to content

Remove extension based content script cosmetic filtering #9487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bbondy opened this issue Apr 27, 2020 · 3 comments
Closed

Remove extension based content script cosmetic filtering #9487

bbondy opened this issue Apr 27, 2020 · 3 comments

Comments

@bbondy
Copy link
Member

bbondy commented Apr 27, 2020

We should remove some of these content-script based (via brave-extension) rules since I believe they should be covered by cosmetic filters.

https://github.com/brave/brave-core/blob/master/components/brave_extension/extension/brave_extension/manifest.json#L56

The full assets are here:
https://github.com/brave/brave-core/tree/master/components/brave_extension/extension/brave_extension/assets

The extension way isn't good because:

  • It adds manual things we can't dynamically update
  • It does not work on Android
  • It should be covered already by cosmetic filters

Test plan

Test to make sure with an older build vs this build, that the following sites block the same:

@rebron
Copy link
Collaborator

rebron commented Jun 5, 2020

@bbondy can you assign a priority on this one? p4?

@antonok-edm
Copy link
Collaborator

@bbondy / @rebron Looks like this can be closed? brave/brave-core#5386 (comment)

@bbondy
Copy link
Member Author

bbondy commented Jun 22, 2020

Yes but it was via brave/brave-core#5878
Dupe of #10319

@bbondy bbondy closed this as completed Jun 22, 2020
@bbondy bbondy added the closed/duplicate Issue has already been reported label Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants