Skip to content

don't load unused built-in extensions #9178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bughit opened this issue Apr 13, 2020 · 5 comments
Closed

don't load unused built-in extensions #9178

bughit opened this issue Apr 13, 2020 · 5 comments
Labels
closed/duplicate Issue has already been reported closed/invalid

Comments

@bughit
Copy link

bughit commented Apr 13, 2020

Description

The following extensions/processes should not be loaded when their functionality is not activated:

  • Utility: Bat Ledger Service (nothing related to BAT has been activated)
  • Utility: Bat Ads Service (nothing related to BAT has been activated)
  • Extension: Crypto Wallets (nothing related to wallets has been activated)

Brave version (brave://version info)

Brave: 1.5.123 Chromium: 80.0.3987.163 (Official Build) (64-bit)
Revision: e7fbe071abe9328cdce4ffedac9822435fbd3656-refs/branch-heads/3987@{#1037}
OS: Windows 7 Service Pack 1 (Build 7601.24550)
@congard
Copy link

congard commented Apr 14, 2020

+1

Brave: 1.9.14 Chromium: 81.0.4044.92 (Official Build) unknown (64-bit)
Revision: 0
ОS: Linux

@NejcZdovc NejcZdovc added the closed/duplicate Issue has already been reported label Apr 14, 2020
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Apr 14, 2020
@NejcZdovc NejcZdovc reopened this Apr 14, 2020
@NejcZdovc
Copy link
Contributor

NejcZdovc commented Apr 14, 2020

dupe of #5429 and #9196

@bughit
Copy link
Author

bughit commented Apr 14, 2020

@NejcZdovc What insanity is this? You created #9196 after this and then closed this as dup of a newer issue?

You did not even bother to vopy it correctly, there's no mention of "Extension: Crypto Wallets"

And of course #5429, which you closed, has nothing to do with this. This bug does not even mention rewards.

@NejcZdovc
Copy link
Contributor

regarding Extension: Crypto Wallets (nothing related to wallets has been activated). It's disabled when you start a browser. You can try it on a clean profile and you will see that this extension is not running:
image
It will be activated when you visit a site that support dapps.

Yes I created #9196 as you listed 3 processes that are handled by 3 different teams and can't be tracked in one issue. That's why I split it.

Yes I listed #5429 as user was reporting utility as well. Utility: Bat Ledger Service (nothing related to BAT has been activated) is rewards service which will be needed for #9130 like I said in #5429.

@bsclifton
Copy link
Member

bsclifton commented Apr 14, 2020

Thanks for the update, @NejcZdovc

To recap, here are the tracking issues for each item:

And then #5429 closed as wontfix because of "Rewards Everywhere" (captured in #9130)

@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported closed/invalid
Projects
None yet
Development

No branches or pull requests

5 participants