Skip to content

[Android] Opening a new tab opens a custom tab #9037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
srirambv opened this issue Apr 6, 2020 · 1 comment · Fixed by brave/brave-core#5185
Closed

[Android] Opening a new tab opens a custom tab #9037

srirambv opened this issue Apr 6, 2020 · 1 comment · Fixed by brave/brave-core#5185

Comments

@srirambv
Copy link
Contributor

srirambv commented Apr 6, 2020

Description

Opening a new tab opens a custom tab

Steps to reproduce

  1. Add a PWA on the home screen which adds a custom tab
  2. Background PWA and open Brave app
  3. Visit a site in a new tab using the + button on the bottom toolbar
  4. Opens a new custom tab with uneditable URL bar. Have to open the tab in Brave via menu to use the tab

Actual result

custome-tabs

Expected result

Should not switch to custom tab when opening a new tab after launching a PWA

Issue reproduces how often

Easy

Issue happens on

  • Current Play Store version? Yes on 1.5.120
  • Beta build? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device (Phone, Tablet, Phablet): Phone
  • Android version: 10

Brave version

1.5.120

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

@srirambv
Copy link
Contributor Author

srirambv commented Apr 24, 2020

Verification passed on OnePlus 6T with Android 10 running 1.7.100 x64 stable build

  • Verified opening a new tab opens a normal tab

Verification passed on Asus Zenfone (x86) with Android 6 running 1.7.102 BraveModernx86.apk

  • Verified opening a new tab opens a normal tab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants