Skip to content

Remove HasSameDomainAndPath from bat_helper #7153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
NejcZdovc opened this issue Nov 29, 2019 · 1 comment
Closed

Remove HasSameDomainAndPath from bat_helper #7153

NejcZdovc opened this issue Nov 29, 2019 · 1 comment
Labels
closed/invalid closed/not-actionable feature/rewards

Comments

@NejcZdovc
Copy link
Contributor

We should remove HasSameDomainAndPath from bat_helper and just use GURL. The only reference that I found for it is in twitch.cc
@NejcZdovc NejcZdovc added dev-concern feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Nov 29, 2019
@NejcZdovc NejcZdovc removed the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Apr 10, 2020
@NejcZdovc
Copy link
Contributor Author

will be fixed with #9133 as we will remove this code

@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Apr 10, 2020
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed/invalid closed/not-actionable feature/rewards
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bbondy @NejcZdovc