Subclass `ToolbarTablet` instead of overriding the behavior by changing the superclass #46133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

6 tasks

samartnik opened this issue May 16, 2025 · 0 comments

Labels

dev-concern OS/Android

Contributor

samartnik commented May 16, 2025

Description

To avoid direct patches of ToolbarTablet we should subclass it and make changes in our class instead. Issue related to brave/brave-core#29087

Steps to reproduce

n/a

Actual result

n/a

Expected result

n/a

Reproduces how often

Easily reproduced

Brave version

n/a

Device

Brand/model: n/a
Android version: n/a

Channel information

release (stable)
beta
nightly

Reproducibility

with Brave Shields disabled
with Brave Rewards disabled
in the latest version of Chrome

Miscellaneous information

No response

The text was updated successfully, but these errors were encountered:

samartnik added dev-concern OS/Android labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment