download icons quickly flash yellow after keeping insecure download - follow up of #45159

[kjozwiak]

Description

The following issue is a follow up of #45159.

When downloading an insecure file, you'll notice that when clicking on keep, the download icon will quickly flash yellow due to the ! icon and then continue to use the expected colours while the file is being downloaded. If the file has already been downloaded/cached and just requires a decision re: keeping/discarding, the download icon will also quickly flash yellow before being saved on the HD/locally.

Steps to reproduce

Test Case #1 - Saving cached insecure download

1. install/launch 1.79.37 Chromium: 135.0.7049.52 (or any build that has the issue)
2. download an insecure file as mentioned via [cr135 follow up] Regression of download indicator for insecure downloads. #45159 (comment)
3. once you receive the insecure icon, wait ~3-5min for the download to complete/get cached (waiting on decision re: keeping or discarding)
4. click on Keep and you'll notice the download icon quickly flash yellow before saving the file locally/to the HD

Test Case #2 - Keeping/Complete insecure download

1. install/launch 1.79.37 Chromium: 135.0.7049.52 (or any build that has the issue)
2. download an insecure file as mentioned via [cr135 follow up] Regression of download indicator for insecure downloads. #45159 (comment)
3. once you receive the insecure icon, click on Keep
4. you'll notice the download icon quickly flash yellow before the download resumes/completes using the regular download colours

Actual result

Example #1 following Test Case #1 above:

Recording.2025-04-07.163741.mp4

Example #2 following Test Case #2 above:

Recording.2025-04-07.163956.mp4

Expected result

We shouldn't be displaying any yellow when users click on Keep when saving an insecure file.

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave | 1.79.37 Chromium: 135.0.7049.52 (Official Build) nightly (64-bit)
-- | --
Revision | a3ad03a075e376dcad5b5976ef142fc608173d63
OS | Windows 11 Version 24H2 (Build 26100.3476)

Channel information

• release (stable)
• beta
• nightly

Reproducibility

• with Brave Shields disabled
• with Brave Rewards disabled
• in the latest version of Chrome

Miscellaneous information

No response