Skip to content

Update icons for Tab Groups menu #43792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 of 6 tasks
rebron opened this issue Feb 6, 2025 · 2 comments · Fixed by brave/brave-core#27552
Closed
3 of 6 tasks

Update icons for Tab Groups menu #43792

rebron opened this issue Feb 6, 2025 · 2 comments · Fixed by brave/brave-core#27552
Assignees
@fallaciousreasoning
Labels
misc/icons OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.77.x - Release

Comments

@rebron
Copy link
Collaborator

rebron commented Feb 6, 2025

Description

The icons for the Tabs Group menu should be consistent with Nala icons.

Steps to reproduce

  1. Create a new tab group.
  2. Right click on the tab group.
  3. Notice icons on the menu.

Actual result

Image

Expected result

[placeholder]

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.75.x

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 6, 2025
@rebron rebron moved this to P3 backlog in Front End Feb 6, 2025
@aguscruiz
Copy link

aguscruiz commented Feb 6, 2025 •
edited
Loading

Added the following icons to Nala:

  • group-new-tab
  • group-move-new-window
  • group-ungroup
  • group-close
Image

@fallaciousreasoning fallaciousreasoning mentioned this issue Feb 7, 2025
Merged
24 tasks
@rebron rebron moved this from P3 backlog to In progress in Front End Feb 7, 2025
@brave-builds brave-builds added this to the 1.77.x - Nightly milestone Feb 9, 2025
@rebron rebron moved this from In progress to Completed in Front End Feb 18, 2025
@MadhaviSeelam
Copy link

MadhaviSeelam commented Mar 7, 2025 •
edited
Loading

Verification PASSED using

Brave | 1.77.75 Chromium: 134.0.6998.45 (Official Build) beta (64-bit)
-- | --
Revision | 48fcf82fb7cf2a2142388c4b3179ff0215971fc3
OS | Windows 11 Version 24H2 (Build 26100.3194)
  1. Installed 1.77.75
  2. launched Brave
  3. opened few tabs
  4. created a tab group (News) via tab context menu
  5. Right click on the tab group
  6. confirmed new icons are shown in the bubble matched to [Nala]: Update tab group icons brave-core#27552 (comment)
Light Dark
Image Image

@rebron rebron removed this from Front End Mar 31, 2025
@LaurenWags LaurenWags mentioned this issue Apr 1, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fallaciousreasoning fallaciousreasoning

Labels
misc/icons OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.77.x - Release
Development

Successfully merging a pull request may close this issue.

[Nala]: Update tab group icons brave/brave-core
5 participants
@rebron @fallaciousreasoning @aguscruiz @brave-builds @MadhaviSeelam