Clarify search suggestions toggle and expand on-device functionality beyond Google

[ShivanKaul]

Description

If Show search suggestions is turned off in brave://settings/search, we still use an on-device model to generate suggestions based on what the user is typing in the omnibox. However, we only do this for Google. Also, the current text is not super clear.

PROPOSAL:

1. Use on-device model no matter what the default search engine is (not just Google)
2. Change toggle label and description to be:

Toggle name: Improve search suggestions
Toggle description: When on, Brave sends what you type in the address bar or search box to your default search engine to get better suggestions. When off, Brave only shows suggestions generated on your device. This is always off in private windows.

Steps to reproduce

1. Go to brave://settings/search
2. Check Show search suggestions toggle and description
3. Turn OFF
4. See if you get search suggestions using local model (i.e. no new network requests to any search engine)
5. Try with a few different default search engines (including Google)

Actual result

1. Currently the toggle text is not completely accurate (we still "show" search suggestions if the toggle is off using the local model when Google is the default search provider, and the description is correct but not complete)
2. We only use the local model if default search engine is Google

Expected result

See PROPOSAL above.

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.77.5 Chromium: 133.0.6943.39 (Official Build) nightly (arm64)

Channel information

• release (stable)
• beta
• nightly

Reproducibility

• with Brave Shields disabled
• with Brave Rewards disabled
• in the latest version of Chrome

Miscellaneous information

No response

[MadhaviSeelam]

Verification PASSED using

Brave | 1.77.77 Chromium: 134.0.6998.45 (Official Build) beta (64-bit)
-- | --
Revision | d38d18575f181dbe15d2251fb4113330333bbcb7
OS | Windows 11 Version 24H2 (Build 26100.3194)

Case 1: Brave as default SE when `Improve search suggestions` is disabled - PASSED

1. Installed 1.77.75
2. launched Brave
3. opened brave://settings/search
4. confirmed the toggle label changed from Show search suggestions to Improve search suggestions
5. confirmed the text matches to screenshot mentioned in Enable on-device suggestions model for all search providers. brave-core#27526 (comment)
6. leave Brave as default search engine
7. turned off the Improve search suggestions toggle
8. typed Lond in Normal window search/omni box
9. confirmed search suggestions using local model are shown (i.e. no new network requests to any search engine)
10. typed Lond search widget
11. verified Enable search suggestions? dialog shown
12. opened private window
13. typed London in the address bar
14. confirmed search suggestions using local model are shown (i.e. no new network requests to any search engine)

step 4-7	step 9	step 11	step 14

Case 2: Non-Brave (DDG) as default SE (both normal & private windows) when `Improve search suggestions` is disabled - PASSED

1. New profile
2. launched Brave
3. opened brave://settings/search
4. confirmed the toggle label changed from Show search suggestions to Improve search suggestions
5. confirmed the text matches to screenshot mentioned in Enable on-device suggestions model for all search providers. brave-core#27526 (comment)
6. change DDG as default search engine for both normal & private windows
7. turned off the Improve search suggestions toggle
8. typed London in Normal window search/omni box
9. confirmed search suggestions using local model are shown (i.e. no new network requests to any search engine)
10. typed London in the address bar
11. confirmed search suggestions using local model are shown (i.e. no new network requests to any search engine)

step 4 - 7	step 8	step 11

Case 3: Non-Brave (Google) as default SE (both normal & private windows) when `Improve search suggestions` is disabled

1. New profile
2. launched Brave
3. opened brave://settings/search
4. confirmed the toggle label changed from Show search suggestions to Improve search suggestions
5. confirmed the text matches to screenshot mentioned in Enable on-device suggestions model for all search providers. brave-core#27526 (comment)
6. change Google as default search engine for both normal & private windows
7. turned off the Improve search suggestions toggle
8. typed London in Normal window search/omni box
9. confirmed search suggestions using local model (i.e. no new network requests to any search engine) as expected
10. typed London in the address bar
11. confirmed search suggestions using local model are shown (i.e. no new network requests to any search engine) as expected

step 4 - 7	step 8	step 11

Case 4: Brave as default SE when `Improve search suggestions` is enabled- PASSED

1. Installed 1.77.75
2. launched Brave
3. opened brave://settings/search
4. leave Brave as default search engine
5. turned off the Improve search suggestions toggle
6. typed Lond in Normal window search/omni box
7. confirmed search suggestions using local model & new network requests as expected
8. opened private window
9. typed London in the address bar
10. confirmed search suggestions using local model are shown (i.e. no new network requests to any search engine)

step 4 - 7	step 8	step 11