Skip to content

Shortcut in the commander show incorrect key binding order instead of the originally created order #43129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 of 6 tasks
MadhaviSeelam opened this issue Jan 6, 2025 · 1 comment
Assignees
Labels
feature/keyboard-shortcuts good first issue OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/Test-Plan-Specified QA/Yes

Comments

@MadhaviSeelam
Copy link

Description

Found while testing #41412. Created shortcut key binding Ctrl + Shift + E in brave://settings/system/shortcuts for Export all bookmarks. However, this key binding order in commander is not same and it's shown as Shift + Ctrl + E. But both key bindings work to export bookmarks.

Steps to reproduce

  1. Install 1.75.145
  2. launch Brave
  3. opened brave://settings/system/shortcuts
  4. created a key binding Ctrl + Shift + E
  5. opened a new tab and pressed Ctrl + Spacebar or hamburger menu >>Quick commands
  6. type Export all bookmarks

Actual result

Shift + Ctrl + E is shown

example example
Image Image

Expected result

correct order should be shown i.e. Ctrl + Shift + E

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave | 1.75.145 Chromium: 132.0.6834.57 (Official Build) nightly (64-bit)
-- | --
Revision | 4ecdecd1626892f9f317e9d8154c50cf8459d3bf
OS | Windows 11 Version 24H2 (Build 26100.2605)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

@fallaciousreasoning @rebron

@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Jan 7, 2025
@rebron rebron moved this to P4 Backlog in General Jan 7, 2025
@rebron rebron added polish Nice to have — usually related to front-end/visual tasks good first issue labels Jan 7, 2025
@fallaciousreasoning
Copy link

I had a quick look at this - it'll be a pretty difficult fix because the internal shortcut representation doesn't support ordering 😒

I'm going to mark this is p5

@fallaciousreasoning fallaciousreasoning removed the status in General Jan 8, 2025
@fallaciousreasoning fallaciousreasoning moved this to P5 Backlog / waiting upstream in General Jan 8, 2025
@fallaciousreasoning fallaciousreasoning added priority/P5 Not scheduled. Don't anticipate work on this any time soon. and removed priority/P4 Planned work. We expect to get to it "soon". labels Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/keyboard-shortcuts good first issue OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/Test-Plan-Specified QA/Yes
Projects
Status: P5 Backlog / waiting upstream
Development

No branches or pull requests

3 participants