Skip to content

[hackerone] iframe download popup origin confusion #42772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
diracdeltas opened this issue Dec 9, 2024 · 4 comments · Fixed by brave/brave-core#26953
Closed

[hackerone] iframe download popup origin confusion #42772

diracdeltas opened this issue Dec 9, 2024 · 4 comments · Fixed by brave/brave-core#26953
Labels
OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/No QA/Test-All-Platforms release-notes/exclude security

Comments

@diracdeltas diracdeltas added priority/P2 A bad problem. We might uplift this to the next planned release. security labels Dec 9, 2024
@diracdeltas
Copy link
Member Author

diracdeltas commented Dec 9, 2024

@LaurenWags
Copy link
Member

@brave/qa-team should put verification notes under https://github.com/brave/internal/issues/1238.

@LaurenWags
Copy link
Member

LaurenWags commented Dec 17, 2024

Requires 1.74.30 or higher for verification 👍🏻

Can use something like https://bravesoftware.slack.com/archives/CHGKGMHDJ/p1734455218877249?thread_ts=1734418637.386749&cid=CHGKGMHDJ for release notes.

@kjozwiak
Copy link
Member

As discussed with @diracdeltas, the above needs a follow up which will be fixed/completed via #42939. We'll want to uplift #42939 into 1.74.x as well so labelling #42939 as release/blocking so it doesn't fall through the cracks. Labelling the following issue as QA/No and release-notes/exclude as we'll verify the fix via #42939.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/No QA/Test-All-Platforms release-notes/exclude security
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants