Skip to content

Add extra checks on ViewProvider class methods #42728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SergeyZhukovsky opened this issue Dec 6, 2024 · 0 comments · Fixed by brave/brave-core#26915
Closed

Add extra checks on ViewProvider class methods #42728

SergeyZhukovsky opened this issue Dec 6, 2024 · 0 comments · Fixed by brave/brave-core#26915
Assignees
@SergeyZhukovsky
Labels
OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/include
Milestone
1.75.x - Release

Comments

@SergeyZhukovsky
Copy link
Member

We override ViewProvider inside BraveAutocompleteCoordinator. We need to add checks on it's methods in case upstream adds a new one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SergeyZhukovsky SergeyZhukovsky

Labels
OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/include
Projects
None yet
Milestone
1.75.x - Release
Development

Successfully merging a pull request may close this issue.

Adds extra check on ViewProvider class methods in bytecode tests on Android brave/brave-core
2 participants
@SergeyZhukovsky @brave-builds