-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Make System prompt input area bigger to show the place holder text #42589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Additionally, @jonathansampson would it be possible to change the text fields/areas to Nala components? https://nala.bravesoftware.com/?path=/docs/components-input--docs |
Definitely can give that a look. Should it be merged with this issue, or split off into its own? |
Up to you, I'm fine either way. Thank you! |
@aguscruiz Just submitted brave/leo#924 to introduce support for multiline/textarea components. If that can land, it will open us up to using it in this context. |
@srirambv Do you think it is necessary to make the input field tall enough to show the entire system prompt? Or would it be sufficient if the field could scroll, enabling the user to view the entire system prompt. I lean more towards scrolling, since we don't know how tall the user's display is, and the system prompt is likely to cause scrolling on smaller displays (e.g., mobile screens). If we size the input to the prompt height, we might wind up making the input control taller than the screen itself. The changes I made via brave/leo#925 introduce support for |
Personally not fan of scroll bars but brave/leo#925 seems like a good solution. |
Verification passed on
![]() ![]() ![]() |
Description
Make System prompt input area bigger to show the place holder text
Steps to reproduce
Actual result
Expected result
maybe something like
Reproduces how often
Easily reproduced
Brave version (brave://version info)
Channel information
Reproducibility
Miscellaneous information
cc: @jonathansampson @mattmcalister
The text was updated successfully, but these errors were encountered: